Closed Bug 1404811 Opened 2 years ago Closed 2 years ago

[Form Autofill] Remove the skip-if=debug metadata in mochitest.ini for test_basic_creditcard_autocomplete_form.html

Categories

(Toolkit :: Form Manager, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: ralin, Assigned: ralin)

References

Details

(Whiteboard: [form autofill:MVP])

Attachments

(1 file)

No longer spot the leak on m-c, see the latest TH result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5516189608dd495b87e3c9a48e05f109bd1df32, I believe we can remove skip-if=debug and let mochitest protect credit card related features in beta channel.

(also see https://bugzilla.mozilla.org/show_bug.cgi?id=1401454#c5 for further discussion about leak problem)
(discussed with Sean, he still found the leak in his build, need a further check before jump into this)
Assignee: nobody → ralin
Hey Luke,

Do you think we're confident enough about the TH result[0] to say it's ready to land? Thanks


[0]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0156b43ae71079ec5fa977ced3c9b1e660907bd
Flags: needinfo?(lchang)
Comment on attachment 8914228 [details]
Bug 1404811 - Enable test_basic_creditcard_autocomplete_form.html mochitest in beta channel.

https://reviewboard.mozilla.org/r/185546/#review191732
Attachment #8914228 - Flags: review?(lchang) → review+
Looks good to go.
Flags: needinfo?(lchang)
Thanks for reviewing :D
Status: NEW → ASSIGNED
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/514e421ea3c3
Enable test_basic_creditcard_autocomplete_form.html mochitest in beta channel. r=lchang
https://hg.mozilla.org/mozilla-central/rev/514e421ea3c3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.