Closed
Bug 1404811
Opened 7 years ago
Closed 7 years ago
[Form Autofill] Remove the skip-if=debug metadata in mochitest.ini for test_basic_creditcard_autocomplete_form.html
Categories
(Toolkit :: Form Manager, enhancement, P3)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: ralin, Assigned: ralin)
References
Details
(Whiteboard: [form autofill:MVP])
Attachments
(1 file)
No longer spot the leak on m-c, see the latest TH result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5516189608dd495b87e3c9a48e05f109bd1df32, I believe we can remove skip-if=debug and let mochitest protect credit card related features in beta channel. (also see https://bugzilla.mozilla.org/show_bug.cgi?id=1401454#c5 for further discussion about leak problem)
|
Assignee | |
Comment 1•7 years ago
|
||
(discussed with Sean, he still found the leak in his build, need a further check before jump into this)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ralin
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•7 years ago
|
||
Hey Luke, Do you think we're confident enough about the TH result[0] to say it's ready to land? Thanks [0]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0156b43ae71079ec5fa977ced3c9b1e660907bd
Flags: needinfo?(lchang)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 5•7 years ago
|
||
Rebased on top of today's m-c, looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98dfc62895a6d5d9aba07db07b1a8d34d173df39
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8914228 [details] Bug 1404811 - Enable test_basic_creditcard_autocomplete_form.html mochitest in beta channel. https://reviewboard.mozilla.org/r/185546/#review191732
Attachment #8914228 -
Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/514e421ea3c3 Enable test_basic_creditcard_autocomplete_form.html mochitest in beta channel. r=lchang
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/514e421ea3c3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•