Closed Bug 1404854 Opened 3 years ago Closed 3 years ago

Cannot scroll page by dragging text selection handles to the edge of the screen

Categories

(Firefox for Android :: Text Selection, defect, P2)

All
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
fennec + ---
firefox55 --- wontfix
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: JanH, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Scrolling up is barely possible, although not very pleasant, while scrolling down by dragging the selection handle doesn't seem to work at all.
Kats, botond, what do you think about this? Feels like APZ needs to be aware that you're dragging a selection handle around then scroll for you.
tracking-fennec: ? → +
Flags: needinfo?(bugmail)
Flags: needinfo?(botond)
Priority: -- → P2
I think this is more in the selection code than APZ. Even on desktop if you do a mouse-drag-selection, the page will scroll if you select stuff beyond the edge of the visible page, and APZ has nothing to do with that. It's handled by the selection code.
Flags: needinfo?(bugmail)
AccessibleCaretManager::DragCaretInternal() has some code [1] to scroll the page, but apparently, it didn't work properly. I'll look into it.

[1] https://dxr.mozilla.org/mozilla-central/rev/19b32a138d08f73961df878a29de6f0aad441683/layout/base/AccessibleCaretManager.cpp#1283-1288
Assignee: nobody → tlin
Status: NEW → ASSIGNED
Flags: needinfo?(botond)
Comment on attachment 8915917 [details]
Bug 1404854 Part 1 - Move null pointers checking from DragCaretInternal() to DragCaret().

https://reviewboard.mozilla.org/r/187170/#review193410
Attachment #8915917 - Flags: review?(mtseng) → review+
Comment on attachment 8915918 [details]
Bug 1404854 Part 2 - Move adding mOffsetYToCaretLogicalPosition into DragCaretInternal().

https://reviewboard.mozilla.org/r/187172/#review193414
Attachment #8915918 - Flags: review?(mtseng) → review+
Comment on attachment 8915919 [details]
Bug 1404854 Part 3 - Fix page cannot be scrolled automatically when dragging caret.

https://reviewboard.mozilla.org/r/187174/#review193416
Attachment #8915919 - Flags: review?(mtseng) → review+
Morris, thanks for the review!
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e5e53f0cfa8
Part 1 - Move null pointers checking from DragCaretInternal() to DragCaret(). r=mtseng
https://hg.mozilla.org/integration/autoland/rev/d5fc6f59adce
Part 2 - Move adding mOffsetYToCaretLogicalPosition into DragCaretInternal(). r=mtseng
https://hg.mozilla.org/integration/autoland/rev/cc0c99d812fd
Part 3 - Fix page cannot be scrolled automatically when dragging caret. r=mtseng
We've shipped this bug in 2 releases already AFAICT. Given that we're trying to limit uplifts for 57 to bugs that would be potentially driving a dot release, I'm going to mark this as wontfix for 57. Feel free to set it back to affected and request Beta approval if you feel strongly about it.
This is a long-standing issue, so I'm OK to let this ride the train.
You need to log in before you can comment on or make changes to this bug.