1404877 - Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

this should be only about testing that we don't mix console.time in different tabs.

Comment 1

[Soledad Penades [:sole] [:spenades]]

Attachment: Bug 1404877 - Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend.

Review commit: https://reviewboard.mozilla.org/r/220858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220858/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8951548 [details]
Bug 1404877 - Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend.

https://reviewboard.mozilla.org/r/220858/#review226792

I only have one comment, but the test is already working and is ready to land imo. Thanks a lot Sole !

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_time_methods.js:48
(Diff revision 1)
> -  BrowserTestUtils.loadURI(gBrowser.selectedBrowser, TEST_URI3);
> -
> -  yield waitForMessages({
> -    webconsole: hud2,
> +  let message1 = await new Promise(resolve => {
> +    setTimeout(() => {
> +      resolve(findMessage(hud2, "bTimer started"));
> +    }, 250);
> -    messages: [{
> -      name: "bTimer started",
> -      consoleTime: "bTimer",
> -    }],
>    });

so, instead of waiting for an arbitrary number of milliseconds, could we have in the support file a "smoke signal" message just after the console.time ?

```js
function foo() {
  console.timeEnd("aTimer");
}
console.time("aTimer");
foo();
console.time("bTimer");
console.log("smoke signal")
```

(or something better in the log).
The console API guarantee us that smoke signal would be printed after a message for console.time("bTimer").

So we could do :
```js
await waitFor(() => findMessage(hud2, "smoke signal"));
is(findMessage(hud2, "bTimer started"), null, "no message is printed:...")
```

what do you think of this ?

Comment 3

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8951548 [details]
Bug 1404877 - Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220858/diff/1-2/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8951548 [details]
Bug 1404877 - Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend.

https://reviewboard.mozilla.org/r/220858/#review226830

thanks sole :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c8e6e3303c
Migrate browser_webconsole_bug_658368_time_methods.js to the new frontend. r=nchevobbe

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/06c8e6e3303c