Remove "Gross hack" from nsViewSourceChannel::BuildViewSourceURI

RESOLVED FIXED in Firefox 63

Status

()

P5
normal
RESOLVED FIXED
2 years ago
7 months ago

People

(Reporter: mayhemer, Assigned: dpino)

Tracking

({good-first-bug})

Trunk
mozilla63
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment, 4 obsolete attachments)

Assign this as a P3 bug since this is a follow-up of bug 1403998 comment #6. @mayhemer feel free to adjust the priority if necessary.
Priority: -- → P3
Whiteboard: [necko-triaged]
(Reporter)

Updated

a year ago
Keywords: good-first-bug
Priority: P3 → P5
(Reporter)

Comment 3

7 months ago
Comment on attachment 9000183 [details] [diff] [review]
0001-Remove-Gross-hack-from-nsViewSourceChannel-BuildView.patch

Review of attachment 9000183 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #9000183 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 4

7 months ago
:mayhemer Could you help me push the patch to the try server? (this is my first patch).
(Reporter)

Comment 5

7 months ago
(In reply to dpino@igalia.com from comment #4)
> :mayhemer Could you help me push the patch to the try server? (this is my
> first patch).

Please update the patch commit message to a form:
Bug NNNNNN - Short description of what the patch does, r=mayhemer

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7856aa31d6b2df9ba7a19ddae118adb8e5d2ba62
(Assignee)

Comment 6

7 months ago
Updated patch with correct message format.
Attachment #9000183 - Attachment is obsolete: true
Attachment #9001277 - Flags: checkin?
(Assignee)

Updated

7 months ago
Attachment #9001277 - Flags: checkin?
(Reporter)

Comment 7

7 months ago
Comment on attachment 9001277 [details] [diff] [review]
0001-Bug-1405022-Remove-Gross-hack-from-nsViewSourceChann.patch

Please update the message to something like:
"remove unnecessary use of nsAutoCString from call to ... bla bla"

to check in, use the checkin-needed keyword
(Reporter)

Updated

7 months ago
Assignee: nobody → dpino
Status: NEW → ASSIGNED
(Assignee)

Comment 8

7 months ago
Keywords: checkin-needed
(Assignee)

Comment 9

7 months ago
Keywords: checkin-needed
Attachment #9001277 - Attachment is obsolete: true
Attachment #9001280 - Attachment is obsolete: true
(Reporter)

Comment 10

7 months ago
Please:

Bug 1405022 - Remove unnecessary use of nsAutoCString from the call to NS_NewURI in 
nsViewSourceChannel::BuildViewSourceURI, r=mayhemer

and there is a bugzilla field for keywords (under the Tracking section).
(Assignee)

Comment 11

7 months ago
Attachment #9001281 - Attachment is obsolete: true
(Assignee)

Updated

7 months ago
Keywords: checkin-needed
(Assignee)

Comment 12

7 months ago
Thanks for your tips and patience :) Hopefully everything is fine now.

Comment 13

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f80952f55006
Remove unnecessary use of nsAutoCString from the call to NS_NewURI in nsViewSourceChannel::BuildViewSourceURI. r=mayhemer
Keywords: checkin-needed

Comment 14

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f80952f55006
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
status-firefox58: affected → ---
You need to log in before you can comment on or make changes to this bug.