1405022 - Remove "Gross hack" from nsViewSourceChannel::BuildViewSourceURI

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P5)

Description

[Honza Bambas (:mayhemer)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1403998#c6

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Assign this as a P3 bug since this is a follow-up of bug 1403998 comment #6. @mayhemer feel free to adjust the priority if necessary.

Comment 2

[Diego Pino]

Attachment: 0001-Remove-Gross-hack-from-nsViewSourceChannel-BuildView.patch

I removed the cast to nsAutoCString, as in https://searchfox.org/mozilla-central/source/extensions/cookie/nsPermissionManager.cpp#729

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 9000183 [details] [diff] [review]
0001-Remove-Gross-hack-from-nsViewSourceChannel-BuildView.patch

Review of attachment 9000183 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 4

[Diego Pino]

:mayhemer Could you help me push the patch to the try server? (this is my first patch).

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to [e-mail] from comment #4)
> :mayhemer Could you help me push the patch to the try server? (this is my
> first patch).

Please update the patch commit message to a form:
Bug NNNNNN - Short description of what the patch does, r=mayhemer

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7856aa31d6b2df9ba7a19ddae118adb8e5d2ba62

Comment 6

[Diego Pino]

Attachment: 0001-Bug-1405022-Remove-Gross-hack-from-nsViewSourceChann.patch

Updated patch with correct message format.

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 9001277 [details] [diff] [review]
0001-Bug-1405022-Remove-Gross-hack-from-nsViewSourceChann.patch

Please update the message to something like:
"remove unnecessary use of nsAutoCString from call to ... bla bla"

to check in, use the checkin-needed keyword

Comment 8

[Diego Pino]

Attachment: 0001-Bug-1405022-Remove-unnecessary-use-of-nsAutoCString-.patch

Keywords: checkin-needed

Comment 9

[Diego Pino]

Attachment: 0001-Bug-1405022-Remove-unnecessary-use-of-nsAutoCString-.patch

Keywords: checkin-needed

Comment 10

[Honza Bambas (:mayhemer)]

Please:

Bug 1405022 - Remove unnecessary use of nsAutoCString from the call to NS_NewURI in 
nsViewSourceChannel::BuildViewSourceURI, r=mayhemer

and there is a bugzilla field for keywords (under the Tracking section).

Comment 11

[Diego Pino]

Attachment: 0001-Bug-1405022-Remove-unnecessary-use-of-nsAutoCString-.patch

Comment 12

[Diego Pino]

Thanks for your tips and patience :) Hopefully everything is fine now.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f80952f55006
Remove unnecessary use of nsAutoCString from the call to NS_NewURI in nsViewSourceChannel::BuildViewSourceURI. r=mayhemer

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f80952f55006