Closed Bug 1405022 Opened 3 years ago Closed 2 years ago

Remove "Gross hack" from nsViewSourceChannel::BuildViewSourceURI

Categories

(Core :: Networking, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mayhemer, Assigned: dpino)

Details

(Keywords: good-first-bug, Whiteboard: [necko-triaged])

Attachments

(1 file, 4 obsolete files)

Assign this as a P3 bug since this is a follow-up of bug 1403998 comment #6. @mayhemer feel free to adjust the priority if necessary.
Priority: -- → P3
Whiteboard: [necko-triaged]
Keywords: good-first-bug
Priority: P3 → P5
Comment on attachment 9000183 [details] [diff] [review]
0001-Remove-Gross-hack-from-nsViewSourceChannel-BuildView.patch

Review of attachment 9000183 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #9000183 - Flags: review?(honzab.moz) → review+
:mayhemer Could you help me push the patch to the try server? (this is my first patch).
(In reply to dpino@igalia.com from comment #4)
> :mayhemer Could you help me push the patch to the try server? (this is my
> first patch).

Please update the patch commit message to a form:
Bug NNNNNN - Short description of what the patch does, r=mayhemer

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7856aa31d6b2df9ba7a19ddae118adb8e5d2ba62
Updated patch with correct message format.
Attachment #9000183 - Attachment is obsolete: true
Attachment #9001277 - Flags: checkin?
Attachment #9001277 - Flags: checkin?
Comment on attachment 9001277 [details] [diff] [review]
0001-Bug-1405022-Remove-Gross-hack-from-nsViewSourceChann.patch

Please update the message to something like:
"remove unnecessary use of nsAutoCString from call to ... bla bla"

to check in, use the checkin-needed keyword
Assignee: nobody → dpino
Status: NEW → ASSIGNED
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #9001277 - Attachment is obsolete: true
Attachment #9001280 - Attachment is obsolete: true
Please:

Bug 1405022 - Remove unnecessary use of nsAutoCString from the call to NS_NewURI in 
nsViewSourceChannel::BuildViewSourceURI, r=mayhemer

and there is a bugzilla field for keywords (under the Tracking section).
Keywords: checkin-needed
Thanks for your tips and patience :) Hopefully everything is fine now.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f80952f55006
Remove unnecessary use of nsAutoCString from the call to NS_NewURI in nsViewSourceChannel::BuildViewSourceURI. r=mayhemer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f80952f55006
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.