1405039 - Avoid using nsINode::GetChildAt() in HTMLEditor::GetSelectedElement()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Comment 1

[(no longer active)]

Attachment: Avoid using nsINode::GetChildAt() in HTMLEditor::GetSelectedElement()

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8914405 [details] [diff] [review]
Avoid using nsINode::GetChildAt() in HTMLEditor::GetSelectedElement()

>+nsIContent*
>+Selection::GetChildAtFocusOffset()
>+{
>+  if (!mAnchorFocusRange)
>+    return nullptr;

Put {}.

>@@ -2374,26 +2374,20 @@ HTMLEditor::GetSelectedElement(const nsAString& aTagName,
>   }
> 
>   if (!bNodeFound) {
>     if (isLinkTag) {
>       // Link tag is a special case - we return the anchor node
>       //  found for any selection that is totally within a link,
>       //  included a collapsed selection (just a caret in a link)
>       nsCOMPtr<nsINode> anchorNode = selection->GetAnchorNode();
>-      int32_t anchorOffset = -1;
>-      if (anchorNode) {
>-        anchorOffset = selection->AnchorOffset();
>-      }
>+      nsIContent* anchorChild = selection->GetChildAtAnchorOffset();
> 
>       nsCOMPtr<nsINode> focusNode = selection->GetFocusNode();
>-      int32_t focusOffset = -1;
>-      if (focusNode) {
>-        focusOffset = selection->FocusOffset();
>-      }
>+      nsIContent* focusChild = selection->GetChildAtAnchorOffset();

GetChildAtFocusOffset()?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/259952e0c0b0
Avoid using nsINode::GetChildAt() in HTMLEditor::GetSelectedElement(); r=masayuki

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/259952e0c0b0