1405054 - Move permission strings to toolkit

Status: RESOLVED WONTFIX

(WebExtensions :: General, enhancement, P3)

Description

[Tomislav Jovanovic :zombie]

We currently duplicate strings between desktop and android (see [1]), even for permissions not supported on android, which, doesn't seem ideal.

Andrew points to bug 1379833 comment 13 as reason, but I don't understand that:

"If we moved the strings, we'd need to re-translate them using Memory, so let's add duplicate strings (that will also need to be re-translated using Memory)"

That seems like we now have two problems, so I must be missing something.


1) https://mail.mozilla.org/pipermail/dev-addons/2017-September/003155.html

Comment 1

[Andrew Swan [:aswan]]

See also bug 1379833 comment 15.
In any case, I defer to the l10n team for what works best here.

Comment 2

[Francesco Lodolo [:flod]]

For a start, I wasn't expecting us to be adding 5/6 permissions per cycle.

At the time, the choice was between:
a) Let's move all permissions to /toolkit, and ship not localized text for both browser and mobile until locales catch up.
b) Duplicate them, and rely on translation memory in localization tools to speed up translation for mobile.

This concern still remain valid (from bug 1379833 comment #13)

> The UI doc says that we're going to use the same text on Android and
> Desktop. I think the screenshot above from desktop shows that, while the
> actual permissions might be the same, it's hard to keep the exact same UI
> and text: on mobile the first permission could potentially end up out of
> screen on a small phone (also, "Cancel" vs "CANCEL"). 
> So, permission strings can potentially be still scattered across multiple
> places (/browser, /mobile, and some shared in /toolkit).

If we can make sure the mobile UI scales properly to fit longer translations, and we keep adding permissions at this rate, I guess we need to bite the bullet and move them to a shared file.

Comment 3

[Rob Wu [:robwu]]

Fenix doesn't use permission strings from Gecko, but from Android-Components. That does mean that these strings are currently obsolete, I filed bug 1671453 for that.