1405165 - Intermittent leakcheck | default process: 14673 bytes leaked (BackstagePass, CondVar, ConsoleReportCollector, HttpBaseChannel, LoadInfo, ...)

Status: RESOLVED INCOMPLETE

(Toolkit :: Safe Browsing, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: aiakab [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=134483053&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/b5eqlY_ASwyHOj-Owm3oqg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

1 failures in 824 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-10-02&endday=2017-10-08&tree=all

Comment 2

[Intermittent Failures Robot]

2 failures in 912 pushes (0.002 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-10-23&endday=2017-10-29&tree=all

Comment 3

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup

Comment 4

[Intermittent Failures Robot]

3 failures in 889 pushes (0.003 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 2
* mozilla-inbound: 1

Platform breakdown:
* osx-10-10: 2
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-12-04&endday=2017-12-10&tree=all

Comment 5

[Intermittent Failures Robot]

8 failures in 423 pushes (0.019 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 3
* autoland: 3
* mozilla-inbound: 2

Platform breakdown:
* osx-10-10: 4
* linux64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-12-11&endday=2017-12-17&tree=all

Comment 6

[Intermittent Failures Robot]

15 failures in 590 pushes (0.025 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 7
* autoland: 5
* mozilla-central: 3

Platform breakdown:
* osx-10-10: 8
* linux64: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-12-18&endday=2017-12-24&tree=all

Comment 7

[Intermittent Failures Robot]

4 failures in 147 pushes (0.027 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 2
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* osx-10-10: 3
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2017-12-25&endday=2017-12-31&tree=all

Comment 8

[Intermittent Failures Robot]

5 failures in 462 pushes (0.011 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 4
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-01&endday=2018-01-07&tree=all

Comment 9

[Intermittent Failures Robot]

16 failures in 788 pushes (0.02 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 9
* mozilla-central: 4
* mozilla-inbound: 3

Platform breakdown:
* osx-10-10: 8
* linux64: 6
* windows7-32: 1
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-08&endday=2018-01-14&tree=all

Comment 10

[Intermittent Failures Robot]

15 failures in 141 pushes (0.106 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 6
* mozilla-inbound: 5
* mozilla-central: 4

Platform breakdown:
* osx-10-10: 10
* linux64: 4
* windows7-32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-18&endday=2018-01-18&tree=all

Comment 11

[Noemi Erli[:noemi_erli]]

There are 31 failures in the last 7 days.
Platforms: Linux x64, OS X 10.10, Windows 7 and windows10-64 all debug.
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=157301486

Relevant part of the log:
ERROR - TEST-UNEXPECTED-FAIL | leakcheck | default process: 16380 bytes leaked (BackstagePass, CondVar, ConsoleReportCollector, HttpBaseChannel, LoadInfo, ...)
2531
15:10:59     INFO - 
2532
15:10:59     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 765
2533
15:10:59     INFO - 
2534
15:10:59     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
2535
15:10:59     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
2536
15:10:59     INFO -    0 |TOTAL                                 |       49        0|   44671        0|
2537
15:10:59     INFO - 
2538
15:10:59     INFO - nsTraceRefcnt::DumpStatistics: 781 entries
2539
15:10:59     INFO - 
2540
15:10:59     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
2541
15:10:59     INFO - 
2542
15:10:59     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 766
2543
15:10:59     INFO - 
2544
15:10:59     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
2545
15:10:59     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
2546
15:10:59     INFO -    0 |TOTAL                                 |       46        0|   67108        0|
2547
15:10:59     INFO - 
2548
15:10:59     INFO - nsTraceRefcnt::DumpStatistics: 865 entries
2549
15:10:59     INFO - 
2550
15:10:59     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
2551
15:10:59     INFO - REFTEST INFO | Removed pending crash reports at '/Users/cltbld/Library/Application Support/firefox/Crash Reports'
2552
15:10:59     INFO - REFTEST INFO | Running with e10s: True
2553
15:10:59     INFO - REFTEST INFO | Application command: /Users/cltbld/tasks/task_1516316654/build/application/Firefox NightlyDebug.app/Contents/MacOS/firefox -marionette -foreground -profile /var/folders/vy/_zxsfnfj6ydc3fdzn9_h6dww00000w/T/tmphEMlhe.mozrunner
2554
15:10:59     INFO - ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/vy/_zxsfnfj6ydc3fdzn9_h6dww00000w/T/tmphEMlhe.mozrunner/runreftest_leaks.log
2555
15:11:01     INFO - Unable to read VR Path Registry from /Users/cltbld/Library/Application Support/OpenVR/.openvr/openvrpaths.vrpath
2556
15:11:01     INFO - 1516317061091	Marionette	INFO	Enabled via --marionette
2557

:selenamarie Could you please take a look?

Comment 12

[Intermittent Failures Robot]

32 failures in 657 pushes (0.049 failures/push) were associated with this bug in the last 7 days. 

This is the #27 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 12
* mozilla-inbound: 11
* mozilla-central: 7
* mozilla-beta: 2

Platform breakdown:
* osx-10-10: 22
* linux64: 8
* windows7-32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-15&endday=2018-01-21&tree=all

Comment 13

[Intermittent Failures Robot]

17 failures in 701 pushes (0.024 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 5
* try: 4
* mozilla-inbound: 4
* autoland: 4

Platform breakdown:
* linux64: 10
* osx-10-10: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-22&endday=2018-01-28&tree=all

Comment 14

[Andrew McCreight [:mccr8]]

The failures in the last week are all in debug-test-verify-e10s. I think this is another instance of bug 1432246, due to the presence of URL classifier stuff in the leak. This is either an instance of safe browsing leaking when we shut down the browser too quickly, or maybe that's not expected to work and the test harness is failing to disable safe browsing.

Comment 15

[Intermittent Failures Robot]

30 failures in 735 pushes (0.041 failures/push) were associated with this bug in the last 7 days. 

This is the #34 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* autoland: 12
* mozilla-inbound: 10
* mozilla-central: 8

Platform breakdown:
* osx-10-10: 19
* linux64: 10
* windows10-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-01-29&endday=2018-02-04&tree=all

Comment 16

[Eric Rahm [:erahm]]

Geoff, we think this is more of an issue with the TV suite (see comment 14 and bug 1432246), do you know who can take a look? Our guess is that we should be disabling safe browsing during testing.

Comment 17

[Geoff Brown [:gbrown]]

Thanks Eric. I'll have a preliminary look but may well try to hand this off to someone else. At a glance, I don't see a pref for disabling safe browsing and I don't know the implications of doing that.

Comment 18

[Selena Deckelmann :selenamarie :selena]

Francois - can you help out gbrown?

Comment 19

[François Marier [:francois]]

(In reply to Geoff Brown [:gbrown] from comment #17)
> Thanks Eric. I'll have a preliminary look but may well try to hand this off
> to someone else. At a glance, I don't see a pref for disabling safe browsing
> and I don't know the implications of doing that.

This is how to disable Safe Browsing entirely:

browser.safebrowsing.blockedURIs.enabled = false
browser.safebrowsing.malware.enabled = false
browser.safebrowsing.phishing.enabled = false
plugins.flashBlock.enabled = false
plugins.show_infobar = false
privacy.trackingprotection.annotate_channels = false
privacy.trackingprotection.enabled = false
privacy.trackingprotection.pbmode.enabled = false

Comment 20

[Geoff Brown [:gbrown]]

(In reply to François Marier [:francois] from comment #19)

Thanks! Most of these are already set for reftests (which seem to be causing all the trouble), but one pref is missing.

> This is how to disable Safe Browsing entirely:
> 
> browser.safebrowsing.blockedURIs.enabled = false
> browser.safebrowsing.malware.enabled = false
> browser.safebrowsing.phishing.enabled = false

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/layout/tools/reftest/reftest-preferences.js#92-94

> plugins.flashBlock.enabled = false

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/layout/tools/reftest/reftest-preferences.js#102

> privacy.trackingprotection.annotate_channels = false
> privacy.trackingprotection.enabled = false
> privacy.trackingprotection.pbmode.enabled = false

https://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest-preferences.js?q=file%3Areftest-preferences.js&redirect_type=single#103-105


> plugins.show_infobar = false

Does not appear to be set. I'll see if setting this helps.

Comment 21

[François Marier [:francois]]

(In reply to François Marier [:francois] from comment #19)
> This is how to disable Safe Browsing entirely:
> 
> browser.safebrowsing.blockedURIs.enabled = false
> browser.safebrowsing.malware.enabled = false
> browser.safebrowsing.phishing.enabled = false
> plugins.flashBlock.enabled = false
> plugins.show_infobar = false
> privacy.trackingprotection.annotate_channels = false
> privacy.trackingprotection.enabled = false
> privacy.trackingprotection.pbmode.enabled = false

I forgot one:

  browser.safebrowsing.passwords.enabled = false

This ones is not necessary, but might be good to add too:

  browser.safebrowsing.downloads.enabled = false

This is where the above prefs are used to enable the various Safe Browsing lists:

https://searchfox.org/mozilla-central/rev/7ed2a637dc305e90fed6ffb041c6b8fa162b66bd/toolkit/components/url-classifier/SafeBrowsing.jsm#223-231

Comment 22

[Geoff Brown [:gbrown]]

(In reply to Geoff Brown [:gbrown] from comment #20)
> > plugins.show_infobar = false
> 
> Does not appear to be set. I'll see if setting this helps.

Oh, but plugins.show_infobar = false by default anyway:

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/browser/app/profile/firefox.js#708

Comment 23

[Geoff Brown [:gbrown]]

(In reply to François Marier [:francois] from comment #21)
> I forgot one:
> 
>   browser.safebrowsing.passwords.enabled = false

Got that one already:

https://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest-preferences.js?q=file%3Areftest-preferences.js&redirect_type=single#95

> This ones is not necessary, but might be good to add too:
> 
>   browser.safebrowsing.downloads.enabled = false

That one is not modified in test prefs. I'll try setting it = false.

Comment 24

[Geoff Brown [:gbrown]]

I'm making some minor pref changes in bug 1432246; I'm not too optimistic about those being effective, but worth a try. I'll be watching for new failures.

Comment 25

[Intermittent Failures Robot]

1 failures in 685 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405165&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 26

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup