Closed Bug 1405165 Opened 5 years ago Closed 4 years ago

Intermittent leakcheck | default process: 14673 bytes leaked (BackstagePass, CondVar, ConsoleReportCollector, HttpBaseChannel, LoadInfo, ...)

Categories

(Toolkit :: Safe Browsing, defect, P5)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, memory-leak, Whiteboard: [stockwell unknown])

Keywords: mlk
https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
There are 31 failures in the last 7 days.
Platforms: Linux x64, OS X 10.10, Windows 7 and windows10-64 all debug.
Recent log failure: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=157301486

Relevant part of the log:
ERROR - TEST-UNEXPECTED-FAIL | leakcheck | default process: 16380 bytes leaked (BackstagePass, CondVar, ConsoleReportCollector, HttpBaseChannel, LoadInfo, ...)
2531
15:10:59     INFO - 
2532
15:10:59     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 765
2533
15:10:59     INFO - 
2534
15:10:59     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
2535
15:10:59     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
2536
15:10:59     INFO -    0 |TOTAL                                 |       49        0|   44671        0|
2537
15:10:59     INFO - 
2538
15:10:59     INFO - nsTraceRefcnt::DumpStatistics: 781 entries
2539
15:10:59     INFO - 
2540
15:10:59     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
2541
15:10:59     INFO - 
2542
15:10:59     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 766
2543
15:10:59     INFO - 
2544
15:10:59     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
2545
15:10:59     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
2546
15:10:59     INFO -    0 |TOTAL                                 |       46        0|   67108        0|
2547
15:10:59     INFO - 
2548
15:10:59     INFO - nsTraceRefcnt::DumpStatistics: 865 entries
2549
15:10:59     INFO - 
2550
15:10:59     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
2551
15:10:59     INFO - REFTEST INFO | Removed pending crash reports at '/Users/cltbld/Library/Application Support/firefox/Crash Reports'
2552
15:10:59     INFO - REFTEST INFO | Running with e10s: True
2553
15:10:59     INFO - REFTEST INFO | Application command: /Users/cltbld/tasks/task_1516316654/build/application/Firefox NightlyDebug.app/Contents/MacOS/firefox -marionette -foreground -profile /var/folders/vy/_zxsfnfj6ydc3fdzn9_h6dww00000w/T/tmphEMlhe.mozrunner
2554
15:10:59     INFO - ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/vy/_zxsfnfj6ydc3fdzn9_h6dww00000w/T/tmphEMlhe.mozrunner/runreftest_leaks.log
2555
15:11:01     INFO - Unable to read VR Path Registry from /Users/cltbld/Library/Application Support/OpenVR/.openvr/openvrpaths.vrpath
2556
15:11:01     INFO - 1516317061091	Marionette	INFO	Enabled via --marionette
2557

:selenamarie Could you please take a look?
Flags: needinfo?(sdeckelmann)
Whiteboard: [stockwell needswork]
Component: General → XPConnect
Flags: needinfo?(sdeckelmann)
Whiteboard: [stockwell unknown] → [stockwell unknown] [memShrink]
The failures in the last week are all in debug-test-verify-e10s. I think this is another instance of bug 1432246, due to the presence of URL classifier stuff in the leak. This is either an instance of safe browsing leaking when we shut down the browser too quickly, or maybe that's not expected to work and the test harness is failing to disable safe browsing.
Component: XPConnect → Safe Browsing
Depends on: 1432246
Product: Core → Toolkit
Geoff, we think this is more of an issue with the TV suite (see comment 14 and bug 1432246), do you know who can take a look? Our guess is that we should be disabling safe browsing during testing.
Flags: needinfo?(gbrown)
Whiteboard: [stockwell unknown] [memShrink] → [stockwell unknown]
Thanks Eric. I'll have a preliminary look but may well try to hand this off to someone else. At a glance, I don't see a pref for disabling safe browsing and I don't know the implications of doing that.
Francois - can you help out gbrown?
Flags: needinfo?(francois)
(In reply to Geoff Brown [:gbrown] from comment #17)
> Thanks Eric. I'll have a preliminary look but may well try to hand this off
> to someone else. At a glance, I don't see a pref for disabling safe browsing
> and I don't know the implications of doing that.

This is how to disable Safe Browsing entirely:

browser.safebrowsing.blockedURIs.enabled = false
browser.safebrowsing.malware.enabled = false
browser.safebrowsing.phishing.enabled = false
plugins.flashBlock.enabled = false
plugins.show_infobar = false
privacy.trackingprotection.annotate_channels = false
privacy.trackingprotection.enabled = false
privacy.trackingprotection.pbmode.enabled = false
Flags: needinfo?(francois)
(In reply to François Marier [:francois] from comment #19)

Thanks! Most of these are already set for reftests (which seem to be causing all the trouble), but one pref is missing.

> This is how to disable Safe Browsing entirely:
> 
> browser.safebrowsing.blockedURIs.enabled = false
> browser.safebrowsing.malware.enabled = false
> browser.safebrowsing.phishing.enabled = false

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/layout/tools/reftest/reftest-preferences.js#92-94

> plugins.flashBlock.enabled = false

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/layout/tools/reftest/reftest-preferences.js#102

> privacy.trackingprotection.annotate_channels = false
> privacy.trackingprotection.enabled = false
> privacy.trackingprotection.pbmode.enabled = false

https://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest-preferences.js?q=file%3Areftest-preferences.js&redirect_type=single#103-105


> plugins.show_infobar = false

Does not appear to be set. I'll see if setting this helps.
(In reply to François Marier [:francois] from comment #19)
> This is how to disable Safe Browsing entirely:
> 
> browser.safebrowsing.blockedURIs.enabled = false
> browser.safebrowsing.malware.enabled = false
> browser.safebrowsing.phishing.enabled = false
> plugins.flashBlock.enabled = false
> plugins.show_infobar = false
> privacy.trackingprotection.annotate_channels = false
> privacy.trackingprotection.enabled = false
> privacy.trackingprotection.pbmode.enabled = false

I forgot one:

  browser.safebrowsing.passwords.enabled = false

This ones is not necessary, but might be good to add too:

  browser.safebrowsing.downloads.enabled = false

This is where the above prefs are used to enable the various Safe Browsing lists:

https://searchfox.org/mozilla-central/rev/7ed2a637dc305e90fed6ffb041c6b8fa162b66bd/toolkit/components/url-classifier/SafeBrowsing.jsm#223-231
(In reply to Geoff Brown [:gbrown] from comment #20)
> > plugins.show_infobar = false
> 
> Does not appear to be set. I'll see if setting this helps.

Oh, but plugins.show_infobar = false by default anyway:

https://dxr.mozilla.org/mozilla-central/rev/35dfa0882568c06f2d81b6749179815cd4f82886/browser/app/profile/firefox.js#708
(In reply to François Marier [:francois] from comment #21)
> I forgot one:
> 
>   browser.safebrowsing.passwords.enabled = false

Got that one already:

https://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest-preferences.js?q=file%3Areftest-preferences.js&redirect_type=single#95

> This ones is not necessary, but might be good to add too:
> 
>   browser.safebrowsing.downloads.enabled = false

That one is not modified in test prefs. I'll try setting it = false.
I'm making some minor pref changes in bug 1432246; I'm not too optimistic about those being effective, but worth a try. I'll be watching for new failures.
Flags: needinfo?(gbrown)
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.