1405250 - Migrate browser_webconsole_closure_inspection.js to the new frontend

Status: RESOLVED INACTIVE

(DevTools :: Console, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

migrate variableview test to objectinspector

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The old test was testing that we had a `<Closure>` node in the VariablesView. This node is handled here https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/devtools/client/shared/widgets/VariablesViewController.jsm#440-481.
We don't have that at the moment in the ObjectInspector, and I am not sure we should migrate this feature ?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

This was added in Bug 810966, at the same time than in the debugger if I understand correctly, where the VariableView was used as well. Following https://bugzilla.mozilla.org/show_bug.cgi?id=810966#c1 STR, I don't see it in the debugger as well.

Jason, Yulia, do you think we should add that in both console and debugger ?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1405250 - Migrate browser_webconsole_closure_inspection.js to the new frontend;

This test is compatible with the new console frontend, but genuinely failing since we
don't have the Closure node in the ObjectInspector.

Review commit: https://reviewboard.mozilla.org/r/200720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200720/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Added a patch that migrate the test but fail (and does not test the "<Closure>" node)

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

closing, we'll add proper test if and when we do Bug 1443848