140541 - Lists should be included in html stream when list items are emitted

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Tanu Mutreja]

OL, UL and DL should be smartly included in nsHTMLCopyEncoder::IncludeInContext 
in mozilla/content/base/src/nsDocumentEncoder.cpp.

Based on the fact that a parent tag is included only if the child node is 
completely selected, there must be a generic change for many a tags to be 
included in context. This will resolve quite a few bugs and specifically 
bug#62188 can immediately be closed after fixing this.

Comment 1

[Joe Francis]

Lets leave IncludeInContext() out of this (changing summary). 

If you are saying that ol/ul/dl should be put into the html stream when we have
a contained list item going into the stream, that sounds ok.  The place to do
that is not IncludeInContext() though.

It will require some new functionality in the document encoder.

Comment 2

[Tanu Mutreja]

I do not know this code properly but what I mean here is that OL/DL/UL should be 
included in context or I should say they should be included in the array of 
ancestors when I select the list partially. There is no problem in cases where 
list is fully included in the selected range. Based on my requirement for 
bug# 62188 it should also be included in IncludeInContext().

Comment 3

[Joe Francis]

IncludeInContext() does the following: it chooses what tags will be forced into
the html stream if they are anywhere in the parent hierarchy of what is being
encoded.

That's not what you want.

You want to include OL/UL/DL only if one of it's list items is being encoded
too.  That is a totally different requirement from IncludeInContext() is doing.

If you make IncludeInContext() emit OL/UL/DL, then you will not be able to copy
a work from inside a list wthout getting terrible results (something like:
<ol>foo</ol>).

Comment 4

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 5

[Joe Francis]

[ushing these out as far as bugzilla will let me.  I'll pull them back as I work
on them.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:hsinyi, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Do you know if this issue is still valid?

Comment 8

[Henri Sivonen (:hsivonen)]

We put only the list items in the main payload and then we put the list itself in the context. I think it would be problematic if we started generating a list wrapper for the items in the main payload, so I'm marking this WONTFIX, but this is a soft WONTFIX. That is, we can reopen if someone who understands this better can show that we really should be including a list wrapper for the items.