1405417 - Ambiguous typename in ipc/mscom/PassthruProxy.h

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Tom Ritter [:tjr]]

>  In file included from /builds/worker/workspace/build/src/ipc/mscom/PassthruProxy.cpp:7:0,
>                   from /builds/worker/workspace/build/src/obj-firefox/ipc/mscom/Unified_cpp_ipc_mscom0.cpp:47:
>  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mscom/PassthruProxy.h: In static member function 'static RefPtr<T> mozilla::mscom::PassthruProxy::Wrap(mozilla::NotNull<Iface*>)':
>  /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/mscom/PassthruProxy.h:43:5: error: need 'typename' before 'mozilla::mscom::detail::EnvironmentSelector<Iface>::Type' because 'mozilla::mscom::detail::EnvironmentSelector<Iface>' is a dependent scope
>       detail::EnvironmentSelector<Iface>::Type env;
>       ^~~~~~

Fixed by adding the 'typename' keyword per https://stackoverflow.com/questions/3311633/nested-templates-with-dependent-scope#3311640

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1405417 Add typename keyword in ipc/mscom/PassthruProxy.h to resolve ambiguity around member type

Review commit: https://reviewboard.mozilla.org/r/186118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186118/

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8914849 [details]
Bug 1405417 Add typename keyword in ipc/mscom/PassthruProxy.h to resolve ambiguity around member type

https://reviewboard.mozilla.org/r/186118/#review191172

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0c2046983c6
Add typename keyword in ipc/mscom/PassthruProxy.h to resolve ambiguity around member type r=aklotz

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b0c2046983c6