1405439 - Cannot cast nullptr to boolean in VR

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Tom Ritter [:tjr]]

I do not believe it is legal to cast nullptr to boolean, I know for certain it causes an error for MinGW:

> /builds/worker/workspace/build/src/gfx/vr/gfxVROculus.cpp:1113:12: error: converting to 'bool' from 'std::nullptr_t' requires direct-initialization [-fpermissive]

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1405439 Do not cast nullptr to bool implicitly, instead return false in gfx/vr

Review commit: https://reviewboard.mozilla.org/r/186130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186130/

Comment 2

[:kip (Kearwood Gilbert)]

Comment on attachment 8914868 [details]
Bug 1405439 Do not cast nullptr to bool implicitly, instead return false in gfx/vr

https://reviewboard.mozilla.org/r/186130/#review191170

Good catch, thanks!  Indeed, these should be "false" not "nullptr"

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e71f573019a
Do not cast nullptr to bool implicitly, instead return false in gfx/vr r=kip

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5e71f573019a