1405462 - Run the bluebird promise benchmark in some form

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tom S]

We can tell that the v8 team internally runs some kind of bluebird benchmark for promises. We have various issues with promise performance, so it would be good to get something we can track. This requires a bit of an investment to figure out which benchmark would be relevant. http://bluebirdjs.com/docs/benchmarks.html we can see various *-ecmascript6-native.js benchmarks.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

These benchmarks are made for usage under node and use a few node intrinsics: require, process.nextTick etc. So we'd need to adapt them first.

Usage of setTimeout would probably mean running them in a browser and not simply in the shell, which means more variance between runs.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Benjamin Bouvier [:bbouvier] from comment #1)

These benchmarks are made for usage under node and use a few node
intrinsics: require, process.nextTick etc. So we'd need to adapt them first.

Usage of setTimeout would probably mean running them in a browser and not
simply in the shell, which means more variance between runs.

Now that we have node.js in tree does that change something?

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

If we ran it in node.js, we'd not be testing our JavaScript engine but node.js' one, that is v8, so I don't think so (maybe I misunderstood something though). The way to go here would be to implement enough shims in the Spidermonkey JS shell so it could run this benchmark.

:evilpie, :jandem, is promise benchmarking still relevant, though? Do we have other benchmarks for this (maybe six-speed)?

Comment 4

[Jan de Mooij [:jandem]]

IMO promise performance is still important and we can do better, and it would be great to have benchmarks we can run in both our/V8 shells. I'm not sure how representative these benchmarks are though.

Comment 5

[Tom S]

I think for test that use Promises a lot it might almost be easier to run this in the browser. I am sure some of the browser benchmarks already have async code.

Comment 6

[Greg Mierzwinski [:sparky]]

Moving this to "Core :: Javascript Engine". Feel free to move it back if needed.

Can you provide a test that should be added and that is capable of returning some results that we can parse in one of our frameworks? Maybe some of this testing is already covered in the benchmarks we are running now?

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Redirecting to somebody on the JS team.

Comment 8

[Jan de Mooij [:jandem]]

Sorry, I'm not familiar with this benchmark and I'm pretty busy these days. Maybe JetStream 2 has some tests that use promises, but I'm not sure.