1405529 - test_devtools_serviceworker_interception.html fails test-verify due to lingering registration

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement)

Description

[Ben Kelly [:bkelly, not reviewing]]

The test_devtools_serviceworker_interception.html test does not pass with --verify.  This is because we are not cleaning up the registration properly making the test fail on the second try.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make test_devtools_serviceworker_interception.html close its window so its registration cleans up. r=asuth

I don't know if test-verify is important yet (I don't think it is), but this is an easy fix.  We just have to close the controlled client so the registration cleans up.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Geoff, just FYI so you don't waste time investigating this TV failure.

Comment 3

[Geoff Brown [:gbrown]]

Thanks Ben. I agree, it is not important or necessary to follow-up on test-verify failures when they only indicate harmless issues. Still, great to see you taking action here.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Ah, I was a bit confused.  I thought this failure would show up in other TV runs, but apparently these tests are only triggered when the test itself is modified in the push.

Anyway, still good to fix it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05f110f2d1f
Make test_devtools_serviceworker_interception.html close its window so its registration cleans up. r=asuth

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b05f110f2d1f