Closed Bug 1405529 Opened 3 years ago Closed 3 years ago

test_devtools_serviceworker_interception.html fails test-verify due to lingering registration

Categories

(Core :: DOM: Service Workers, enhancement)

57 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The test_devtools_serviceworker_interception.html test does not pass with --verify.  This is because we are not cleaning up the registration properly making the test fail on the second try.
I don't know if test-verify is important yet (I don't think it is), but this is an easy fix.  We just have to close the controlled client so the registration cleans up.
Attachment #8914991 - Flags: review?(bugmail)
Geoff, just FYI so you don't waste time investigating this TV failure.
Thanks Ben. I agree, it is not important or necessary to follow-up on test-verify failures when they only indicate harmless issues. Still, great to see you taking action here.
Attachment #8914991 - Flags: review?(bugmail) → review+
Ah, I was a bit confused.  I thought this failure would show up in other TV runs, but apparently these tests are only triggered when the test itself is modified in the push.

Anyway, still good to fix it.
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b05f110f2d1f
Make test_devtools_serviceworker_interception.html close its window so its registration cleans up. r=asuth
https://hg.mozilla.org/mozilla-central/rev/b05f110f2d1f
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.