140553 - Remaining instance of uri filter.

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Matthew Tuck [:CodeMachine]]

I was having a discussion on IRC about the general uselessness of the URI filter
compared to url_quote, and it came up we still have an instance of the uri
filter, this line in bug/edit.html.tmpl.

<a href="[% bug.bug_file_loc FILTER uri %]">URL:</a>

This needs to be fixed.

Firstly, the uri filter shouldn't be there.  If the URL entered is invalid, then
clicking the URL should not take you to a magically valid URL.  This would
discourage fixed up invalid URLs.

There is no "let's be safe" here, invalid URLs shouldn't hurt anyone (correct me
if I'm wrong).

Secondly, and more worryingly, this needs to be html filtered.

Comment 1

[Gervase Markham [:gerv]]

I'm on the case. :-)

Gerv

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Remove two instances of "uri" from bug/edit.html.tmpl.

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 81422 [details] [diff] [review]
Patch v.1

Looks sensible. r=bbaetz x2

Comment 4

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done

Gerv