Closed
Bug 140553
Opened 23 years ago
Closed 23 years ago
Remaining instance of uri filter.
Categories
(Bugzilla :: Creating/Changing Bugs, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: CodeMachine, Assigned: gerv)
Details
Attachments
(1 file)
1.03 KB,
patch
|
bbaetz
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
I was having a discussion on IRC about the general uselessness of the URI filter
compared to url_quote, and it came up we still have an instance of the uri
filter, this line in bug/edit.html.tmpl.
<a href="[% bug.bug_file_loc FILTER uri %]">URL:</a>
This needs to be fixed.
Firstly, the uri filter shouldn't be there. If the URL entered is invalid, then
clicking the URL should not take you to a magically valid URL. This would
discourage fixed up invalid URLs.
There is no "let's be safe" here, invalid URLs shouldn't hurt anyone (correct me
if I'm wrong).
Secondly, and more worryingly, this needs to be html filtered.
Reporter | ||
Updated•23 years ago
|
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.16
Assignee | ||
Comment 1•23 years ago
|
||
I'm on the case. :-)
Gerv
Assignee | ||
Comment 2•23 years ago
|
||
Remove two instances of "uri" from bug/edit.html.tmpl.
Gerv
Comment 3•23 years ago
|
||
Comment on attachment 81422 [details] [diff] [review]
Patch v.1
Looks sensible. r=bbaetz x2
Attachment #81422 -
Flags: review+
Assignee | ||
Comment 4•23 years ago
|
||
Fixed.
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v <--
edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Gerv
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•