1405557 - clang-format not bracing single line if/for/while statements

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Nicholas Nethercote [inactive]]

Attachment: test file

When I run `./mach clang-format -p` on the attached file it doesn't get changed. Ideally the if, while and for blocks would be braced.

Comment 1

[Nicholas Nethercote [inactive]]

Hmm, https://stackoverflow.com/questions/26111162/can-clang-format-add-braces-to-single-line-if-statements-etc suggests that clang-format can't insert braces. glandium suggested that it's designed to only change whitespace. That's disappointing.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Mike is correct. However, we already have ways to fix that in-tree with clang-tidy.

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> Mike is correct. However, we already have ways to fix that in-tree with
> clang-tidy.

Is there a `mach` command, or something similar, to fix braces with clang-tidy?

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Yes, I have been working on this to give it to you.
It should be:
./mach static-analyzer check --check google-readability-braces-around-statements --fix js/src/asmjs/
but this is blocked by bug 1405602