1405598 - Restyle prefread.cpp

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

I'm going to try using clang-format to restyle all of modules/libpref/. As a first step I'm trying out the following three-step process for prefread.cpp:

- Run clang-format on it to fix whitespace.

- Do manual fix-ups, e.g. add braces, rename things.

- Run clang-format again to do additional whitespace fixes

I will post the patches separately for review, but combine them before landing.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1405598 - Restyle prefread.cpp (clang-format 1). .

Review commit: https://reviewboard.mozilla.org/r/186320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186320/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1405598 - Restyle prefread.cpp (manual). .

Review commit: https://reviewboard.mozilla.org/r/186322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186322/

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1405598 - Restyle prefread.cpp (clang-format 3). .

Review commit: https://reviewboard.mozilla.org/r/186324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186324/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8915062 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 1). .

https://reviewboard.mozilla.org/r/186320/#review191664

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8915064 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 3). .

https://reviewboard.mozilla.org/r/186324/#review191666

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8915063 [details]
Bug 1405598 - Restyle prefread.cpp (manual). .

https://reviewboard.mozilla.org/r/186322/#review191668

::: modules/libpref/prefread.cpp:55
(Diff revision 1)
>  static const char kPref[] = "pref";
>  static const char kPrefSticky[] = "sticky_pref";
>  static const char kTrue[] = "true";
>  static const char kFalse[] = "false";
>  
> -/**
> +// This function will increase the size of the buffer owned by the given pref

I'm not particularly a fan of using // on large comments.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21f762390e63416f410c54da438d4b93de355882
Bug 1405598 - Restyle prefread.cpp. r=glandium.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/21f762390e63