Status

()

enhancement
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

2 years ago
I'm going to try using clang-format to restyle all of modules/libpref/. As a first step I'm trying out the following three-step process for prefread.cpp:

- Run clang-format on it to fix whitespace.

- Do manual fix-ups, e.g. add braces, rename things.

- Run clang-format again to do additional whitespace fixes

I will post the patches separately for review, but combine them before landing.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8915062 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 1). .

https://reviewboard.mozilla.org/r/186320/#review191664
Attachment #8915062 - Flags: review?(mh+mozilla) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8915064 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 3). .

https://reviewboard.mozilla.org/r/186324/#review191666
Attachment #8915064 - Flags: review?(mh+mozilla) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8915063 [details]
Bug 1405598 - Restyle prefread.cpp (manual). .

https://reviewboard.mozilla.org/r/186322/#review191668

::: modules/libpref/prefread.cpp:55
(Diff revision 1)
>  static const char kPref[] = "pref";
>  static const char kPrefSticky[] = "sticky_pref";
>  static const char kTrue[] = "true";
>  static const char kFalse[] = "false";
>  
> -/**
> +// This function will increase the size of the buffer owned by the given pref

I'm not particularly a fan of using // on large comments.
Attachment #8915063 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/21f762390e63
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee

Updated

2 years ago
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.