Closed Bug 1405598 Opened 8 years ago Closed 8 years ago

Restyle prefread.cpp

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(3 files)

I'm going to try using clang-format to restyle all of modules/libpref/. As a first step I'm trying out the following three-step process for prefread.cpp: - Run clang-format on it to fix whitespace. - Do manual fix-ups, e.g. add braces, rename things. - Run clang-format again to do additional whitespace fixes I will post the patches separately for review, but combine them before landing.
Attachment #8915062 - Flags: review?(mh+mozilla) → review+
Attachment #8915064 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8915063 [details] Bug 1405598 - Restyle prefread.cpp (manual). . https://reviewboard.mozilla.org/r/186322/#review191668 ::: modules/libpref/prefread.cpp:55 (Diff revision 1) > static const char kPref[] = "pref"; > static const char kPrefSticky[] = "sticky_pref"; > static const char kTrue[] = "true"; > static const char kFalse[] = "false"; > > -/** > +// This function will increase the size of the buffer owned by the given pref I'm not particularly a fan of using // on large comments.
Attachment #8915063 - Flags: review?(mh+mozilla) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: