Closed
Bug 1405598
Opened 8 years ago
Closed 8 years ago
Restyle prefread.cpp
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(3 files)
I'm going to try using clang-format to restyle all of modules/libpref/. As a first step I'm trying out the following three-step process for prefread.cpp:
- Run clang-format on it to fix whitespace.
- Do manual fix-ups, e.g. add braces, rename things.
- Run clang-format again to do additional whitespace fixes
I will post the patches separately for review, but combine them before landing.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8915062 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 1). .
https://reviewboard.mozilla.org/r/186320/#review191664
Attachment #8915062 -
Flags: review?(mh+mozilla) → review+
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8915064 [details]
Bug 1405598 - Restyle prefread.cpp (clang-format 3). .
https://reviewboard.mozilla.org/r/186324/#review191666
Attachment #8915064 -
Flags: review?(mh+mozilla) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8915063 [details]
Bug 1405598 - Restyle prefread.cpp (manual). .
https://reviewboard.mozilla.org/r/186322/#review191668
::: modules/libpref/prefread.cpp:55
(Diff revision 1)
> static const char kPref[] = "pref";
> static const char kPrefSticky[] = "sticky_pref";
> static const char kTrue[] = "true";
> static const char kFalse[] = "false";
>
> -/**
> +// This function will increase the size of the buffer owned by the given pref
I'm not particularly a fan of using // on large comments.
Attachment #8915063 -
Flags: review?(mh+mozilla) → review+
![]() |
Assignee | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/21f762390e63416f410c54da438d4b93de355882
Bug 1405598 - Restyle prefread.cpp. r=glandium.
![]() |
||
Comment 8•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
![]() |
Assignee | |
Updated•8 years ago
|
Blocks: prefs-cleanup
Updated•7 years ago
|
Assignee: nobody → n.nethercote
You need to log in
before you can comment on or make changes to this bug.
Description
•