1405604 - [Regression] The clipboard is incorrectly cleared after following specific steps

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 21b363679
Device: iPhone 6S
iOS: 10.3.3



Steps to reproduce:
1. Go to Settings and turn Offer to Go to Copied link On
2. Open a new tab and go to youtube.com
3. Long tap on the URL bar and copy the link
4. Double tap on Home button and close Firefox
5. Re-open Firefox
6. Background Firefox by pressing the home button once

Actual results:
- The clipboard is cleared. This can be seen in the Today Widget or by trying to paste the previous copied link in the URL bar.

Expected results:
- The clipboard should not be cleared.

Note:
- Issue reproducible on both iOS 11.x and iOS 10.x

See video here:
- https://www.youtube.com/watch?v=xh4o8UY9azk

Comment 1

[Justin D'Arcangelo [:justindarc]]

Taking this since :jhugman is on PTO this week.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 3

[Richard Newman [:rnewman]]

Discussed on Slack, but in short: we shouldn't need to read the clipboard on exit at all. And, indeed, checking on exit is wrong.

We should:

1. Check the clipboard when we enter the foreground, and decide whether to show the toast.
2. Update our saved string from that value as we read it.
3. Update our saved string *when the user copies a URL within Firefox*.

then everything should work.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8921149 [details] [review]
GitHub Pull Request

Carrying over R+ from Slack.

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/49b84434f60aa24782e43bb916b1173b6cfd166f

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/1d048b52a49bd672e0f2de75fe6578f55a9a7e62

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on master d80fd66a7 and beta 10.0 (7473). The clipboard is no longer cleared after following the STR.