1405613 - Update Phabricator version and ensure extensions do not break - Oct 2017

Status: RESOLVED FIXED

(Conduit :: Phabricator, defect)

Description

[Israel Madueme [:imadueme]]

We also are about 6-8 weeks behind upstream so now is a good time to upgrade to test that our extensions do not break.

- Update the pinned commit SHA of the Phabricator version to use (should be in the mozphab dockerfile).
- Rebuild the local test environment, follow instructions at https://github.com/mozilla-services/phabricator-extensions/blob/master/TEST_PLAN.md if you don't know how to build it.
- Follow instructions in the TEST_PLAN doc as a quick way to test if everything sorta works as expected.
- Do more detailed tests to ensure our extensions aren't broken.
- [Side note] Don't forget about Bug 1402374, test if revision autoclosing is fixed in the new version.

Comment 1

[Israel Madueme [:imadueme]]

I rebuilt with the following SHA's, the lastest on Oct 2, 2017

```
# From https://github.com/phacility/phabricator/commits/stable
ENV PHABRICATOR_GIT_SHA 4390a274c1d83eb71f3d6d6211fd58644a6059f4
# From https://github.com/phacility/arcanist/commits/stable
ENV ARCANIST_GIT_SHA e88a8c077b3355af0f4f75fbe95d7a4b1239088b
# From https://github.com/phacility/libphutil/commits/stable
ENV LIBPHUTIL_GIT_SHA 8f4eee3bfbbbdada9126b3b0fc8dfbf07e70a9b8
```

Everything I tested worked properly including 

logging in/out
signing up a brand new user and logging in to phab
submitting a diff
phab making the attachment on the bug
updating the policy when a bug is marked as secure
copying the r+ over to bugzilla
the link to bmo

and just in general I did not find any breakage in Phabricator's normal (non-extended) functionalities.