1405643 - Polish customize overflow panel help some more

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[:Gijs (he/him)]

STR:

0. open customize mode
1. put something like 10 items in the overflow panel
2. reduce the height of the browser window

ER:

things start overflowing beyond the bounds of the panel

AR:

they shouldn't do that.


This goes away if I remove the min-height on the panel.

Comment 1

[:Gijs (he/him)]

Additional issues:
- the header weight is too light on Windows
- the label should read "Overflow Menu" instead of "Overflow Panel"

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs from comment #1)
> Additional issues:
> - the header weight is too light on Windows

Per discussion with Aaron, scratch this again...

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1405643 - ensure items don't spill out of the panel on small window sizes in customize mode,

Review commit: https://reviewboard.mozilla.org/r/186410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186410/

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1405643 - swap out overflow panel label to say 'menu' instead of 'panel',

Review commit: https://reviewboard.mozilla.org/r/186412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186412/

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8915161 [details]
Bug 1405643 - ensure items don't spill out of the panel on small window sizes in customize mode,

https://reviewboard.mozilla.org/r/186410/#review191478

Comment 6

[Osmose [:osmose, :mkelly]]

Comment on attachment 8915162 [details]
Bug 1405643 - swap out overflow panel label to say 'menu' instead of 'panel',

https://reviewboard.mozilla.org/r/186412/#review191542

LGTM!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a485a712da1
ensure items don't spill out of the panel on small window sizes in customize mode, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/2d56c6204130
swap out overflow panel label to say 'menu' instead of 'panel', r=mkelly

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1a485a712da1
https://hg.mozilla.org/mozilla-central/rev/2d56c6204130

Comment 9

[Md. Majedul islam]

I have reproduced this Bug with Nightly 58.0a1 (2017-10-04) on Ubuntu 16.04, 64 Bit!

The bug's fix is now verified on latest Nightly 58.0a1

Build ID     20171006100327
User Agent   Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 10

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 57.0a1 (2017-10-04)  on windows 10 (32-bit)

this bug is verified fix with  latest nightly 58.0a1 (2017-10-06) (32-bit)

Build ID: 20171006100327
Mozilla/5.0 (Windows NT 10.0; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171004]

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9986e0e0ef6c

Comment 12

[Emil Ghitta, QA [:emilghitta]]

I have reproduced the issue mentioned in comment 0 using an affected Firefox 58.0a1 build (BuildId:20171004220309).

I have verified that the issue is not reproducible using Firefox 57.0b7 (Build Id:20171009192146) and 58.0a1(BuildId:20171010220102) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.

Thanks Majedul and Rahimul for the help!