Closed Bug 1405810 Opened 4 years ago Closed 3 years ago
.resist Fingerprinting=true breaks cmd keyboard shortcuts for Google Docs on OSX
STR: ./mach run --setpref privacy.resistFingerprinting true Open a google doc (i.e. https://docs.google.com/document/d/1Jah3S9lFMh9Ckrqpd-ZfQON5a2pK_oLBpSaQiXVHCrI/edit) Type something and press cmd+z Expected: Typing is undone Actual: The letter z gets entered (you can press ctrl+z to actually undo the action) This happens with all shortcuts (cut/copy/paste, reload, etc), and it doesn't happen when privacy.resistFingerprinting is false
Brian, Thanks for reporting this issue! I can reproduce this bug on my MacBook Pro. MacOS: Sierra; Version 10.12.6 Firefox Nightly: 58.0a1 (2017-09-20) (64-bit) It seems the [command] key is not working in any shortcut combination. CS or Tim, could you investigate it?
I think it is because we make the user agent look like Windows. http://searchfox.org/mozilla-central/rev/7ba03cebf1dcf3b4c40c85a4efad42a5022cf1ec/toolkit/components/resistfingerprinting/nsRFPService.h#16-19 The keyboard listener then checks ctrl key instead of meta key (command), so hotkeys don't work.
(In reply to Chung-Sheng Fu [:cfu] from comment #2) > I think it is because we make the user agent look like Windows. > The keyboard listener then checks ctrl key instead of meta key (command), so > hotkeys don't work. That makes sense. I tried Tor Browser and it has the same problem. I don't know if we do anything with this issue considering the fact we need to spoof the OS as Windows.
I concur with CS that spoofing User-Agent as window causes this issue. You can see that the shortcuts work well when you using 'control' instead of 'cmd'. Therefore, I believe that this is the root cause.
Ethan, if this is a P2 bug please have someone assigned to it. Alternatively change the priority to P3 and put it in the backlog - thanks.
Tech evangelism to Google, to do better detection of what platform you are? Back to the Tor guys on how or whether they want to fix this?
(In reply to Ethan Tseng [:ethan] - 57 Regression Engineering Support from comment #3) > I don't know if we do anything with this issue considering the fact we need > to spoof the OS as Windows. Do we? Do we really believe we can disguise the OS of the browser from someone who wants to detect it? I think we'll chat about it this week =)
Priority: P2 → P3
4 years ago
Whiteboard: [domsecurity-backlog1][tor] → [domsecurity-backlog1][tor][fingerprinting-breakage]
4 years ago
Depends on: 1404608
See Also: → 1414012
I heard from some colleagues stopped trying the privacy.resistFingerprinting pref because of this breakage. We should try to fix the issue sooner than later.
Priority: P3 → P2
FYI: This is also happening on GitHub - see https://github.com/ghacksuserjs/ghacks-user.js/issues/330
Priority: P2 → P1
Whiteboard: [domsecurity-backlog1][tor][fingerprinting-breakage] → [domsecurity-backlog1][tor][fingerprinting-breakage][fp-triaged]
This should now be fixed with Bug 1404608
Tested on GitHub on FF 59 and Bug 1404608 fixed this issue.
(In reply to Simon Mainey from comment #11) > This should now be fixed with Bug 1404608 Thanks! I double checked it too.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1404608
2 years ago
2 years ago
You need to log in before you can comment on or make changes to this bug.