Closed
Bug 1405821
Opened 9 years ago
Closed 9 years ago
Move microtask handling to CycleCollectedJSContext
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
20.62 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Currently microtask handling is main thread only and in nsContentUtils, but we'll need it everywhere in order to fix Promise scheduling.
This is a preliminary patch to move the code to CycleCollectedJSContext
Should be just code move + some null checks.
remote: View your change here:
remote: https://hg.mozilla.org/try/rev/130390c35b9a39c3c4fc92b0711118dbf6e5c4f6
remote:
remote: Follow the progress of your build on Treeherder:
remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=130390c35b9a39c3c4fc92b0711118dbf6e5c4f6
Attachment #8915316 -
Flags: review?(amarchesini)
Comment 1•9 years ago
|
||
I'd be willing to help fix some of the broken tests, if that would be useful. Feel free to needinfo me if it would.
Comment 2•9 years ago
|
||
Er, that comment was meant for bug 1193394
Updated•9 years ago
|
Attachment #8915316 -
Flags: review?(amarchesini) → review+
| Assignee | ||
Comment 3•9 years ago
|
||
Yeah, this shouldn't yet break anything. The next patch in my queue will break everything :)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/960319673e9c
Move microtask handling to CycleCollectedJSContext, r=baku
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•