1405844 - AAQ fails on mobile when creating a new user (login with existing users works)

Status: VERIFIED FIXED

(support.mozilla.org :: Questions, task, P3)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Attachment: 37500712961_2321fd194f_o.jpg

Tested on Note 8, Android 7, Firefox 52 and Rocket

== Steps to Reproduce ==

On your Android device with Firefox or Rocket

1. Logout of support.mozilla.org

2. support.mozilla.org/questions/new

3. Tap on any product e.g. Firefox Rocket

4. Tap on any category e.g. "Get Started"

5. Tap on "Post a question"

6. Fill in the info under "Create a support account" i.e email, username, password and Tap on "Create my account"

== Expected Result ==

Next screen in process i.e. the screen about confirming your email

== Actual Result ==

"This page doesn't have a mobile optimized versin. Tap here to go back" as per attached screenshot

Comment 1

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

my apologies for not testing this "new SUMO userid" testcase sooner, :giorgos, :bsternthal would it be possible to fix this before launch i.e. by end of business Friday October 6?

Comment 2

[Ben (:bensternthal)]

Some clarifications on this, my understanding of this issue is the following...

*User registration does not work when invoked from the mobile version of the site*

Looking at the code, I think something is wonky around here:

https://github.com/mozilla/kitsune/blob/master/kitsune/users/views.py#L144

It may be my late night reading of the code but I don't see how this ever worked. 

I do not think this is a high priority fix, however if it's trivial lets sort it.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

It seems that csrf token is not POSTed when using the mobile registration form. And as Ben says that must have been broken for quite some time.

While I expected this to be a trivial fix, it appears that it involves unused code, caching, jinja2 macro weirdness and other friendly beasts.

I'm afraid that this could require upgrades of a number of packages and re-writes of different code blocks so it falls under non-trivial category.

Comment 4

[Ben (:bensternthal)]

Changing this to P3, it's not a P1.

We will try and fix within a week or so.

Comment 5

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Ben (:bensternthal) from comment #4)
> Changing this to P3, it's not a P1.
> 
> We will try and fix within a week or so.

Thank-you for the speedy investigation :bensternthal and :giorgos. It would be great to have this fixed before the Firefox Rocket official release on November 7, 2017. (October 9, 2017 is the start of Firefox Rocket Open Beta)

Can we aim for a target date of November 2nd?

Comment 6

[Ben (:bensternthal)]

Yep.

Comment 7

[Safwan Rahman (:safwan)]

Seems like its a problem from Django 1.8 update era. There was a problem with CSRF token for login window that were addressed and fixed by bug 1253528, but the registration flow got missed. Hoping to have a similar fix.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/kitsune

https://github.com/mozilla/kitsune/commit/8d7e978770cc72db8ed47e9d4534a72a55259002
[Bug 1405844] User Registration on mobile fails (#2924)

* [Bug 1405844] User Registration on mobile fails

* Fixing up the mobile aaq registration template

Comment 9

[Giorgos Logiotatidis [:giorgos]]

:safwan provided a fix (thanks!). Pushed to production today.

Comment 10

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

ok sorry for being late to the party, tested note 8, android 7.1.1, firefox 56, i was able to create a new userid bliblip!
thanks for awesome work, :safewan and :giorgos!