About screen still shows old Firefox logo

VERIFIED FIXED in Firefox 57

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: soeren.hentzschel, Assigned: cnevinchen)

Tracking

Trunk
Firefox 58
All
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox-esr52 unaffected, firefox56 unaffected, firefox57+ verified, firefox58 verified)

Details

(Whiteboard: [FNC][SPT58.3][INT])

Attachments

(2 attachments)

Posted image screenshot
The about screen in the setting still shows the old Firefox logo in Firefox Nightly and Firefox Beta.
Severity: normal → enhancement
tracking-fennec: --- → ?
Component: General → Theme and Visual Design
OS: Unspecified → Android
Hardware: Unspecified → All
Version: Firefox 57 → Trunk
[Tracking Requested - why for this release]:

logo needs to be replaced for Firefox 57 otherwise there will be different Firefox logos within the browser.
I agree that the logos should match, but I am not sure the visual team has the cycles to address this. Adding :jwu to this bug to comment. I also don't know if any of the visual redesign took this screen into account.
Flags: needinfo?(topwu.tw)
Hi Carol, do we have new logo for the about screen?
Flags: needinfo?(topwu.tw)
Flags: needinfo?(chuang)
Hi Vance, Wesly, James, Nicole, this seems like a must fix for Fennec 57. Could you please help find an owner? Thanks!
Flags: needinfo?(wehuang)
Flags: needinfo?(vchen)
Flags: needinfo?(snorp)
Flags: needinfo?(nyee)
let me check with XU first, then find an owner for this today.
Flags: needinfo?(vchen)
Flags: needinfo?(snorp)
Flags: needinfo?(nyee)
Flags: needinfo?(cnevinchen)
Flags: needinfo?(wehuang)
Priority: -- → P1
Carol is on it and needs some time to consider the proper usage of the new logo. Plan to come out a solution later today then aligned with Nevin. Hopefully we are able to catch the next Beta tomorrow (we have that for each Thursday & Monday per my understanding?)
Flags: needinfo?(wehuang)
(In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #6)
> Carol is on it and needs some time to consider the proper usage of the new
> logo. Plan to come out a solution later today then aligned with Nevin.
> Hopefully we are able to catch the next Beta tomorrow (we have that for each
> Thursday & Monday per my understanding?)

Only on monday for fennec.
Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

https://reviewboard.mozilla.org/r/190492/#review195822
Attachment #8919608 - Flags: review?(walkingice0204) → review+
Hi Julian, Wesly, please keep in mind that if you want to land a fix in time for next week's Fennec b11 beta build, we need it ready for uplift by Monday 8am PST. Thanks!
Flags: needinfo?(walkingice0204)
Assignee: nobody → cnevinchen
Flags: needinfo?(cnevinchen)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5985d54ddaca
Change about page logo. r=walkingice
Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

Approval Request Comment
[Feature/Bug causing the regression]:Photon change icons
[User impact if declined]: User will see old icons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:no
[Why is the change risky/not risky?]: just change images
[String changes made/needed]:no
Attachment #8919608 - Flags: approval-mozilla-beta?
Thanks Ritu for the reminder. We are aware of the uplift deadline (in fact I thought we have beta builds on both Mon/Thur but then learned from Julien I was wrong), and we'll be able to catch it.

(In reply to Ritu Kothari (:ritu) from comment #11)
> Hi Julian, Wesly, please keep in mind that if you want to land a fix in time
> for next week's Fennec b11 beta build, we need it ready for uplift by Monday
> 8am PST. Thanks!
Flags: needinfo?(wehuang)
Flags: needinfo?(walkingice0204)
Whiteboard: [FNC][SPT58.3][INT]
Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

Polish and should be safe, taking it.
Attachment #8919608 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/5985d54ddaca
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I've provided the asset to Nevin. Clear my ni here. :)
Flags: needinfo?(chuang)
tracking-fennec: ? → +
Verified for both Nightly and Beta. New logo is being displayed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.