1405853 - About screen still shows old Firefox logo

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Sören Hentzschel]

Attachment: screenshot

The about screen in the setting still shows the old Firefox logo in Firefox Nightly and Firefox Beta.

Comment 1

[Sören Hentzschel]

[Tracking Requested - why for this release]:

logo needs to be replaced for Firefox 57 otherwise there will be different Firefox logos within the browser.

Comment 2

[Marcia Knous [:marcia]]

I agree that the logos should match, but I am not sure the visual team has the cycles to address this. Adding :jwu to this bug to comment. I also don't know if any of the visual redesign took this screen into account.

Comment 3

[Jing-wei Wu [:jwu]]

Hi Carol, do we have new logo for the about screen?

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Vance, Wesly, James, Nicole, this seems like a must fix for Fennec 57. Could you please help find an owner? Thanks!

Comment 5

[Wesly Huang (EPM)]

let me check with XU first, then find an owner for this today.

Comment 6

[Wesly Huang (EPM)]

Carol is on it and needs some time to consider the proper usage of the new logo. Plan to come out a solution later today then aligned with Nevin. Hopefully we are able to catch the next Beta tomorrow (we have that for each Thursday & Monday per my understanding?)

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1405853 - Change about page logo.

Review commit: https://reviewboard.mozilla.org/r/190492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190492/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190492/diff/1-2/

Comment 9

[Julien Cristau [:jcristau]]

(In reply to Wesly Huang (Fennec Frontend/Firefox EPM) from comment #6)
> Carol is on it and needs some time to consider the proper usage of the new
> logo. Plan to come out a solution later today then aligned with Nevin.
> Hopefully we are able to catch the next Beta tomorrow (we have that for each
> Thursday & Monday per my understanding?)

Only on monday for fennec.

Comment 10

[Julian Chu [:walkingice]]

Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

https://reviewboard.mozilla.org/r/190492/#review195822

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Julian, Wesly, please keep in mind that if you want to land a fix in time for next week's Fennec b11 beta build, we need it ready for uplift by Monday 8am PST. Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5985d54ddaca
Change about page logo. r=walkingice

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

Approval Request Comment
[Feature/Bug causing the regression]:Photon change icons
[User impact if declined]: User will see old icons
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:no
[Why is the change risky/not risky?]: just change images
[String changes made/needed]:no

Comment 14

[Wesly Huang (EPM)]

Thanks Ritu for the reminder. We are aware of the uplift deadline (in fact I thought we have beta builds on both Mon/Thur but then learned from Julien I was wrong), and we'll be able to catch it.

(In reply to Ritu Kothari (:ritu) from comment #11)
> Hi Julian, Wesly, please keep in mind that if you want to land a fix in time
> for next week's Fennec b11 beta build, we need it ready for uplift by Monday
> 8am PST. Thanks!

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8919608 [details]
Bug 1405853 - Change about page logo.

Polish and should be safe, taking it.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5985d54ddaca

Comment 17

[Carol Huang [:Carol]]

I've provided the asset to Nevin. Clear my ni here. :)

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4aa9ba59cc7

Comment 19

[Bogdan Surd, QA [:bsurd, NI]]

Verified for both Nightly and Beta. New logo is being displayed.