1405917 - When firefox is running in the backround sometimes the password manager window pops up. If left alone for some time firefox will permanently hang.

Status: RESOLVED INCOMPLETE

(Toolkit :: Password Manager, defect)

Description

[fyzzy_navel]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170926190823

Steps to reproduce:

Open firefox and leave open to monitor my Twitch stream.


Actual results:

After a while of playing the game if I have not ever entered my password credentials into the password manager it will pop up randomly and ask for my password. If left unattended this way it ill permanently hang.


Expected results:

Either the password manager window should not pop up randomly or it should not cause firefox to hang.

Comment 1

[Matthew N. [:MattN]]

Do you have Firefox Sync setup?

Not popping up randomly is usually due to Firefox Sync trying to sync or from a background page loading a login form. These are known issues. Do you have tabs open that would load logins forms open? e.g. a session timeout redirects to a login form?

How reproducible is this? Is this a recent regression? You can check with http://mozilla.github.io/mozregression/

Comment 2

[Maire Reavy [:mreavy]]

Kit -- We haven't heard back from the reporter yet.  I see you linked this to the Sync bug about not showing a master-password prompt if one is already open.  Have you seen the browser hang if the password prompt stays up for a long time?  Thanks.

Comment 3

[Lina Butler [:lina]]

Hi Maire, I haven't seen this happen, but ISTR we had issues where we'd show multiple master password prompts, indefinitely. I think Sync makes that more likely because it always prompts if the master password is locked, and doesn't check if a dialog is already open.

Comment 4

[fyzzy_navel]

I do have Sync setup but generally the two tabs i will have open is streamlabs and twitch.tv

The workaround I have been doing is just browsing the internet from anywhere from 3 - 30 minutes till it pops up and then enter my password. I can be scrolling through reddit / feedly / youtube and it will pop up whenever it feels like.

If I dont and just alt tab from my game after too long either the browser will be hung with the password manager requesting the password. If it hasnt crashed yet but has been waiting awhile sometimes it will be very laggy entering my password in. it will take about 2 seconds per character and if i try to enter it and press enter too quick it will not work via those delay input methods.

Comment 5

[Matthew N. [:MattN]]

Thanks for the info. It would help a lot if you could attach a profile when it's laggy but before it hangs as I'm wondering if there is some kind of event loop weirdness causing the issue. You can install the profiler from https://perf-html.io/.

Bug 1382937 would help if the problem is that we're stacking multiple MP dialogs. Bug 1149500 would mitigate this if it's from a login form load in a background tab. Those would likely just be paving over an underlying issue though which can be identified by a profile.

It would be good to know if QA can reproduce this issue by setting up Sync and a Master Password on Windows 10 then restarting the browser and waiting until the MP dialog appears. Once it appears wait longer to see if it gets laggy with text input and capture a profile.

Comment 6

[fyzzy_navel]

Seems like since I clicked the synced tab icon the password manager pops up when i visit the streamlabs page immediately. I downloaded the profiler and will get the data to you as soon as i can.

Comment 7

[fyzzy_navel]

So it hang again yesterday. Does the profiler automatically record or do i have to have it running all the time? because i cant click on the start button in the profiler menu when the password manager is up.

Comment 8

[fyzzy_navel]

https://mega.nz/#!7BFHjIID!PMHCWJ9pJEgVhGE_nFsL25re-pOZcahyvDYw6h9NGz0

Comment 9

[Matthew N. [:MattN]]

That you very much, I assume this is from when the browser started to hang?

I don't see any child process samples, do you have e10s (multi-process) off or were they just not sampled? You can go to about:support and look at the "Multiprocess Windows" line. Does the problem still happen if you enable e10s from about:preferences?

Comment 10

[fyzzy_navel]

I had it running for awhile and it was hanging around the tail end when I exported the data.

Multiprocess Windows 	0/1 (Disabled by add-ons)

is there a way to find out what addon is disabling it? My guess is that it might be all the legacy addons I still have installed :<

Comment 11

[Justin Dolske [:Dolske]]

At this point clearly not fixing for 57 (esp. given it was reported against 56).

Comment 12

[fyzzy_navel]

I removed a lot of the legacy addons and got the multiprocess window attribute to be 1. I'll see if it still lags. I know this is a wontfix flag now but perhaps a workaround can be documented for anyone else who has this problem.

Comment 13

[Matthew N. [:MattN]]

Legacy add-ons don't work in Firefox 57 anyways and that will lead to many more users using multiple processes.

Bug 1382937, fixed in 58, may also help if Sync is setup but that's unclear.

Did you end up seeing this problem anymore?

Comment 14

[Matthew N. [:MattN]]

Re-open if you can still reproduce.