Closed
Bug 1405958
Opened 7 years ago
Closed 7 years ago
Update netmonitor doc to reflect current structure
Categories
(DevTools :: Netmonitor, enhancement)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
Details
Attachments
(1 file)
Current netmonitor doc has some outdate info and we can improve that.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gasolin
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8915477 [details] Bug 1405958 - Update netmonitor doc to reflect current structure; https://reviewboard.mozilla.org/r/186680/#review191740 LGTM. r+ and please fix one issue below. ::: devtools/client/netmonitor/README.md:16 (Diff revision 1) > -Once `node` (`npm` included) is installed, use the following command to install `yarn`. > +Once `node` (`npm` included) is installed, use the following command to install `yarn`, the pacakage dependency management tool. > > ``` > $ npm install -g yarn > ``` I'd prefer to remove this installation guide and use official guide instead https://yarnpkg.com/docs/install. There are plenty of ways to install `yarn`, we should let user decide on their own.
Attachment #8915477 -
Flags: review?(rchien) → review+
Comment hidden (mozreview-request) |
Pushed by flin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ba1e7396bd8 Update netmonitor doc to reflect current structure;r=rickychien
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5ba1e7396bd8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•