Closed Bug 1405973 Opened 8 years ago Closed 8 years ago

Can't select white color for input type="color"

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Product:
Firefox for Android Graveyard
Component:
General
Version:
58 Branch
Platform:
All
Android
Type:
defect

Tracking

(fennec+, firefox56 wontfix, firefox57 verified, firefox58 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
fennec + ---
firefox56 --- wontfix
firefox57 --- verified
firefox58 --- verified

People

(Reporter: luc, Assigned: JanH)

References

Details

Attachments

(1 file)

Bug 1405973 - Add white to basic colour picker.
59 bytes, text/x-review-board-request
jwu
: review+
ritu
: approval-mozilla-beta+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20171003220138 Steps to reproduce: Choose a color from input type="color" on https://luc.frama.io/wemawema/. Actual results: Firefox displays several color, but not white. Expected results: We should be able to choose white.
See Also: → 875750
A quick fix would be to extend our list of provided colours, but otherwise we should finally pick up bug 875750 again to provide a more flexible colour picker.
Status: UNCONFIRMED → NEW
tracking-fennec: --- → ?
Ever confirmed: true
OS: Unspecified → Android
Hardware: Unspecified → All
Please help prioritize this
Flags: needinfo?(wehuang)
Flags: needinfo?(jcheng)
Flags: needinfo?(wehuang)
Priority: -- → P2
tracking-fennec: ? → +
Assignee: nobody → jh+bugzilla
Comment on attachment 8921207 [details] Bug 1405973 - Add white to basic colour picker. https://reviewboard.mozilla.org/r/192202/#review198726
Attachment #8921207 - Flags: review?(topwu.tw) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/0346f1d64c07 Add white to basic colour picker. r=jwu
https://hg.mozilla.org/mozilla-central/rev/0346f1d64c07
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified as fixed on build 58.0a1 from 10/29. Device: Huawei MediaPad M2 (Android 5.1.1)
Status: RESOLVED → VERIFIED
Is this worth nominating for Beta uplift or can it ride the 58 train?
status-firefox56: --- → wontfix
status-firefox57: --- → affected
Flags: needinfo?(jcheng) → needinfo?(jh+bugzilla)
Comment on attachment 8921207 [details] Bug 1405973 - Add white to basic colour picker. Approval Request Comment [Feature/Bug causing the regression]: Colour picker on Android [User impact if declined]: Users can't choose the colour white for a <input type="color"> control. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: None. [Is the change risky?]: No. [Why is the change risky/not risky?]: Just adding white to the fixed list of colours plus a small bit of logic to use a different check mark colour when choosing white. [String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8921207 - Flags: approval-mozilla-beta?
Comment on attachment 8921207 [details] Bug 1405973 - Add white to basic colour picker. Seems like a recent regression, low risk, Beta57+
Attachment #8921207 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on 57.0 build 1. This issue was tested on a Pixer C (Android 8.0) device
status-firefox57: fixed → verified
status-firefox58: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: