1405982 - Rename the method "build_not_win_mac" to match what it is doing

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Sylvestre Ledru [:Sylvestre]]

In bug 1405326, we will probably ignore also Solaris, the method name is no longer relevant.

We could rename it to
is_linker_option_enable()

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1405982 - Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing

Review commit: https://reviewboard.mozilla.org/r/187960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187960/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8916920 [details]
Bug 1405982 - Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing

https://reviewboard.mozilla.org/r/187960/#review193448

::: build/moz.configure/toolchain.configure:1215
(Diff revision 1)
>  imply_option('--enable-linker',
> -             depends_if('--enable-gold', when=build_not_win_mac)(lambda x: 'gold'),
> -             when=build_not_win_mac)
> +             depends_if('--enable-gold', when=is_linker_option_enabled)(lambda x: 'gold'),
> +             when=is_linker_option_enabled)

Actually, this could probably be simplified as imply_option('--enable-linker', 'gold', when='--enable-gold')

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8916920 [details]
Bug 1405982 - Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187960/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/370a4a2a7898
Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing r=glandium

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/370a4a2a7898