Closed Bug 1405982 Opened 2 years ago Closed 2 years ago

Rename the method "build_not_win_mac" to match what it is doing

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

In bug 1405326, we will probably ignore also Solaris, the method name is no longer relevant.

We could rename it to
is_linker_option_enable()
Comment on attachment 8916920 [details]
Bug 1405982 - Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing

https://reviewboard.mozilla.org/r/187960/#review193448

::: build/moz.configure/toolchain.configure:1215
(Diff revision 1)
>  imply_option('--enable-linker',
> -             depends_if('--enable-gold', when=build_not_win_mac)(lambda x: 'gold'),
> -             when=build_not_win_mac)
> +             depends_if('--enable-gold', when=is_linker_option_enabled)(lambda x: 'gold'),
> +             when=is_linker_option_enabled)

Actually, this could probably be simplified as imply_option('--enable-linker', 'gold', when='--enable-gold')
Attachment #8916920 - Flags: review?(mh+mozilla) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/370a4a2a7898
Rename the method "build_not_win_mac" to "is_linker_option_enabled" match what it is doing r=glandium
https://hg.mozilla.org/mozilla-central/rev/370a4a2a7898
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Blocks: 1411462
Product: Core → Firefox Build System
Assignee: nobody → sledru
You need to log in before you can comment on or make changes to this bug.