1406030 - Migrate browser_webconsole_cd_iframe.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1406030 - Enable browser_webconsole_cd_iframe.js in new frontend; .

Once the test was migrated, it was failing because we did not show
error messages for invalid cd() calls.
There was a missing part in the evaluation result prepare message, which
this patch fixes. A stub and a mocha test were added to make sure we do
display those kind of messages.

Review commit: https://reviewboard.mozilla.org/r/199352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199352/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8928104 [details]
Bug 1406030 - Enable browser_webconsole_cd_iframe.js in new frontend; .

https://reviewboard.mozilla.org/r/199352/#review204848

Looks reasonable

Thanks Nicolas,
Honza

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e08a94eae25
Enable browser_webconsole_cd_iframe.js in new frontend; r=Honza.

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4e08a94eae25

Comment 5

[Gerry Chang [:gchang]]

Mass won't fix for 58. Let it ride the train.