Closed Bug 1406039 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_strict_mode_errors.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8942924 [details]
Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

https://reviewboard.mozilla.org/r/213194/#review218874

Thanks Julian, this looks good to me :)
Attachment #8942924 - Flags: review?(nchevobbe) → review+
Comment on attachment 8942924 [details]
Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

https://reviewboard.mozilla.org/r/213194/#review218878

One nit: maybe we could put the data url prefix in a tagged template or a function ?
```
function getDataUri(scriptContent) {
  return `data:text/html;charset=utf8,<script>"use strict;"${scriptContent}</strict>`;
}
```

what do you think ?
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Comment on attachment 8942924 [details]
> Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;
> 
> https://reviewboard.mozilla.org/r/213194/#review218878
> 
> One nit: maybe we could put the data url prefix in a tagged template or a
> function ?
> ```
> function getDataUri(scriptContent) {
>   return `data:text/html;charset=utf8,<script>"use
> strict;"${scriptContent}</strict>`;
> }
> ```
> 
> what do you think ?

Good point, can be nicely mutualized. Updated version is all tiny.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f77e243145f2
migrate browser_webconsole_strict_mode_errors to new frontend;r=nchevobbe
Priority: P2 → P1
https://hg.mozilla.org/mozilla-central/rev/f77e243145f2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.