1406039 - Migrate browser_webconsole_strict_mode_errors.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

Review commit: https://reviewboard.mozilla.org/r/213194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213194/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8942924 [details]
Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

https://reviewboard.mozilla.org/r/213194/#review218874

Thanks Julian, this looks good to me :)

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the review Nicolas! Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8c1b108a042dfc5ef3cd81fe10dc65eab44c681

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8942924 [details]
Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

https://reviewboard.mozilla.org/r/213194/#review218878

One nit: maybe we could put the data url prefix in a tagged template or a function ?
```
function getDataUri(scriptContent) {
  return `data:text/html;charset=utf8,<script>"use strict;"${scriptContent}</strict>`;
}
```

what do you think ?

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8942924 [details]
Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213194/diff/1-2/

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #4)
> Comment on attachment 8942924 [details]
> Bug 1406039 - migrate browser_webconsole_strict_mode_errors to new frontend;
> 
> https://reviewboard.mozilla.org/r/213194/#review218878
> 
> One nit: maybe we could put the data url prefix in a tagged template or a
> function ?
> ```
> function getDataUri(scriptContent) {
>   return `data:text/html;charset=utf8,<script>"use
> strict;"${scriptContent}</strict>`;
> }
> ```
> 
> what do you think ?

Good point, can be nicely mutualized. Updated version is all tiny.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f77e243145f2
migrate browser_webconsole_strict_mode_errors to new frontend;r=nchevobbe

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f77e243145f2