1406085 - enumProperties does not work well for integer indices that are not array indices

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Oriol Brufau [:Oriol]]

When reviewing bug 1403065, I assumed Firefox followed the ECMAScript spec and sorted all integer indices at the beginning. However, it seems it only does so for array indices:

    Reflect.ownKeys({a:1, [2**32-2]: 2, [2**32-1]: 3});
    // [ "4294967294", "a", "4294967295" ]

Therefore, object inspector still skips properties in

    inspect(Object.assign([], {[1]:0, [2**32-1]:0}))

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1406085 - Only consider array indices to be indexed properties.

Review commit: https://reviewboard.mozilla.org/r/186802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186802/

Comment 2

[Oriol Brufau [:Oriol]]

Comment on attachment 8915609 [details]
Bug 1406085 - Only consider array indices to be indexed properties.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186802/diff/1-2/

Comment 3

[Nicolas Chevobbe [:nchevobbe][PTO - back on Monday May 13th]]

Comment on attachment 8915609 [details]
Bug 1406085 - Only consider array indices to be indexed properties.

https://reviewboard.mozilla.org/r/186802/#review192178

Looks good to me, thanks Oriol !

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18b5243c870
Only consider array indices to be indexed properties. r=nchevobbe

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c18b5243c870