Closed Bug 1406108 Opened 2 years ago Closed 2 years ago

Avoid RefPtr copy during iteration in nsPresContext::MediaFeatureValuesChanged

Categories

(Core :: DOM: CSS Object Model, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

References

Details

Attachments

(1 file)

This issue was noted in Bug 1376931#c83 but the fix didn't merge properly before hitting autoland. The local array of RefPtrs built in nsPresContext::MediaFeatureValuesChanged should be iterated without copying the elements.
Attachment #8915652 - Flags: review?(cam)
Comment on attachment 8915652 [details]
Bug 1406108: Make MediaQueryList iteration no longer copy RefPtrs.

https://reviewboard.mozilla.org/r/186838/#review192068

Hooray for automated static analysis. :-)
Attachment #8915652 - Flags: review?(cam) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdfe95610f08
Make MediaQueryList iteration no longer copy RefPtrs. r=heycam
https://hg.mozilla.org/mozilla-central/rev/bdfe95610f08
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.