Closed
Bug 1406108
Opened 7 years ago
Closed 7 years ago
Avoid RefPtr copy during iteration in nsPresContext::MediaFeatureValuesChanged
Categories
(Core :: DOM: CSS Object Model, enhancement)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: bradwerth, Assigned: bradwerth)
References
Details
Attachments
(1 file)
This issue was noted in Bug 1376931#c83 but the fix didn't merge properly before hitting autoland. The local array of RefPtrs built in nsPresContext::MediaFeatureValuesChanged should be iterated without copying the elements.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8915652 -
Flags: review?(cam)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915652 [details]
Bug 1406108: Make MediaQueryList iteration no longer copy RefPtrs.
https://reviewboard.mozilla.org/r/186838/#review192068
Hooray for automated static analysis. :-)
Attachment #8915652 -
Flags: review?(cam) → review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bdfe95610f08
Make MediaQueryList iteration no longer copy RefPtrs. r=heycam
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•