1406121 - Can't view any threads in a crash with no crashing thread

Status: VERIFIED FIXED

(Socorro :: Webapp, task, P2)

Description

[(not currently active) Ted Mielczarek]

We have a number of crash reports with the signature `[@ EMPTY: no crashing thread identified; OK ]` (bug 1385531 is one set of examples) where something is sort of wrong with the dump and we don't have a crashing thread. This itself is not Socorro's fault. However, if you look at one of those reports (like the example in the URL field), you'll notice that you can't see stacks for *any* threads, despite multiple threads existing in the raw dump.

I suspect this is just a bug in the report/index page since we hide non-crashing thread stacks by default. In this case, there's no crashing thread to display, so we probably fail to display the "Click to show other threads" UI. We should just show the stacks for all available threads in this case.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm making this a P2 because it makes it hard to suss out issues with crashes. This would be a good thing to fix soon.

Comment 2

[Stephen A Pohl [:spohl]]

(In reply to Will Kahn-Greene [:willkg] ET needinfo? me from comment #1)
> I'm making this a P2 because it makes it hard to suss out issues with
> crashes. This would be a good thing to fix soon.

I second this. Getting this addressed would be very helpful.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Ted, Stephen: I see this crash in the referenced bug report:

https://crash-stats.mozilla.com/report/index/928f830e-08ea-48d5-aea0-fbb550170729

Are there other good examples that we should test with?

Comment 4

[Stephen A Pohl [:spohl]]

I believe any of these reports can be used to test with:

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=EMPTY%3A%20no%20crashing%20thread%20identified%3B%20OK&date=%3E%3D2017-04-10T15%3A18%3A12.000Z&date=%3C2017-10-10T15%3A18%3A12.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Comment 5

[Osmose [:osmose, :mkelly]]

Attachment: pr 4066: Fix bug 1406121: Display all threads when no crashing thread is available.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/6d021ab19e099889dc91c35465e4a51ad5f890ba
Fix bug 1406121: Display all threads when no crashing thread is available.

https://github.com/mozilla-services/socorro/commit/67789df08b07a4b0dfb4f5d132e5caf36c3fa864
Merge pull request #4066 from Osmose/no-crashing-thread

Fix bug 1406121: Display all threads when no crashing thread is available.

Comment 7

[Osmose [:osmose, :mkelly]]

Verified this on staging with several crash reports from https://crash-stats.allizom.org/signature/?signature=EMPTY%3A%20no%20crashing%20thread%20identified%3B%20OK&date=%3E%3D2017-10-24T05%3A57%3A55.000Z&date=%3C2017-10-31T05%3A57%3A55.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1, seems to be working fine.