Closed
Bug 1406125
Opened 8 years ago
Closed 8 years ago
Fxscreengraph does not wait until the element exists
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | ? | --- |
People
(Reporter: njpark, Assigned: jhugman)
Details
Attachments
(1 file)
In https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/ScreenGraph.swift#L172, waitForElement() doesn't actually wait apparentely.
If the if clause is commented out, the waitForElement should still work - since they should pass the expectation. However, even when the element is visible, this expectation will always fail. Also, increasing timeout has no effect on the waiting duration - it seems to fail instantly all the time.
So currently all our FxScreenGraph using tests are susceptible to an intermittent timing issue.
|
Reporter | |
Comment 1•8 years ago
|
||
I think only James would know best about how to deal with this issue. ni? requested.
Flags: needinfo?(jhugman)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
Flags: needinfo?(jhugman)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8916013 -
Flags: review?(npark)
|
|
Reporter | |
Comment 3•8 years ago
|
||
Comment on attachment 8916013 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3266
LGTM, with an optional comment
Attachment #8916013 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
Merged into master.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
Uplifted to v10.x ce38a0e
You need to log in
before you can comment on or make changes to this bug.
Description
•