Closed Bug 1406160 Opened 2 years ago Closed 2 years ago

Reftest suite-start message contains all tests, even when chunked

Categories

(Testing :: Reftest, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

References

Details

Attachments

(1 file)

When reftests are chunked, the list of tests logged in the suite-start message contains all of the reftests found in all manifests -- including tests not part of the chunk being run. This contributes to the excessive length of the suite-start message noted in bug 1324961.
This reduces the length of the suite-start message to 1/(total-chunks)'th the current length, and accurately reports the tests actually run in the chunk.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=423def6405e1b065cfe0ea76fee9ed275a9735bc
Attachment #8915778 - Flags: review?(ahalberstadt)
Comment on attachment 8915778 [details] [diff] [review]
report tests accurately in chunked reftest suite-start

Review of attachment 8915778 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good, please fix the issue before landing.

::: layout/tools/reftest/reftest.jsm
@@ +593,5 @@
> +
> +                if (gURLs[i].needsFocus && !Focus())
> +                    continue;
> +
> +                if (gURLs[i].slow && !gRunSlowTests)

We don't need to check for these conditions here. I think it was actually a bug that they weren't being logged as part of "suite_start" before. Removing these also means we could use 'gURLs.map(...)' instead of a for loop.
Attachment #8915778 - Flags: review?(ahalberstadt) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad66d82161cf
Adjust chunked reftest suite_start to only report tests run in chunk; r=ahal
https://hg.mozilla.org/mozilla-central/rev/ad66d82161cf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.