Closed Bug 1406164 Opened 3 years ago Closed 3 years ago

Bring eBay back

Categories

(Firefox :: Search, defect, P1)

55 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 + fixed
firefox58 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(2 files, 1 obsolete file)

We're bringing eBay back.
[Tracking Requested - why for this release]: We have a new deal with eBay. We'd like to try to get this into 57, specifically in time for end of year.

Patch will be small, no source code changes, addition of engine, changes to list.json and bringing back tests.
Attached image ebay.ico (obsolete) —
flod:

Anything you can do to make this icon slimmer? I know you are good at that.

FYI, all the UTF8 issues should be worked out.
Assignee: nobody → mozilla
Attachment #8916011 - Flags: feedback?(francesco.lodolo)
Attached image ebay.ico
This one is about one third of the other .ico file

I'll likely take a look at the patch on Monday, it seems like the amount of code might require some dev's eyes though.
Attachment #8916011 - Attachment is obsolete: true
Attachment #8916011 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8916045 [details]
Bug 1406164 - We're bringing eBay back.

https://reviewboard.mozilla.org/r/187304/#review192376

ebay-es, ebay-in, ebay-nl are not used anywhere. Is that expected?

::: browser/locales/search/list.json:44
(Diff revision 2)
> +    "AU": {
> +      "ebay": "ebay-au"
> +    },
> +    "BE": {
> +      "ebay": "ebay-be",
> +      "ebay-fr": "ebay-be"

Can you explain this setting? I don't think I understand what's going on, also for IE

::: browser/locales/searchplugins/ebay-at.xml:8
(Diff revision 2)
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>eBay</ShortName>
> +<Description>eBay - Online auctions</Description>
> +<Image width="16" height="16">data:image/x-icon;base64,AAABAAIAICAAAAEACACoCAAAJgAAABAQAAABAAgAaAUAAM4IAAAoAAAAIAAAAEAAAAABAAgAAAAAAIAEAAAAAAAAAAAAAAABAAAAAAAAAAAAAAUFBQAJBAAAAQgGAAICCgAACAoAAAgMAAgICAAMDAwAFQoAAAITDgAHBRcABgUYAAMSFwAAEhoAERERABoaGgAdHR0AISEhACUlJQA+Pj4AREREAFdXVwBeXl4AYWFhAGlpaQBvb28Ad3d3AHx8fAC8WQAAtF0KAK5VFQC5WxcAwFoAAMtfAADCXxgAyWAAAMxgAADAYwsAyWgLAM1qCwDVYwAA0mQAANZlAADZZgAA22gAAMZhGAAVpXUAFaV4ABewfQA4L8QAMi3NADAs0QA0L98APDLRADUw2wA/NNsAODLlADYx6QA3Mu4AOTPqAEA13gBBNeEAE6SDABSviwAWsIAAF7iGABi4gwAYu4UAGb2GABe7iAAYvYkAFbeSABW6lAAWvJYAFZbEAAOe1wACndsAAp3dABef0QAYp9sAGKreAACf4QADqOUAAqfqAAKn7AAZq+EAAKnwAAKv9QADsPAAA7P0AAO09gAAsfoAArP9AAC0/wD///8AAAAAABQvAAAiUAAAMHAAAD2QAABMsAAAWc8AAGfwAAB4/xEAiv8xAJz/UQCu/3EAwP+RANL/sQDk/9EA////AAAAAAAmLwAAQFAAAFpwAAB0kAAAjrAAAKnPAADC8AAA0f8RANj/MQDe/1EA4/9xAOn/kQDv/7EA9v/RAP///wAAAAAALyYAAFBBAABwWwAAkHQAALCOAADPqQAA8MMAAP/SEQD/2DEA/91RAP/kcQD/6pEA//CxAP/20QD///8AAAAAAC8UAABQIgAAcDAAAJA+AACwTQAAz1sAAPBpAAD/eREA/4oxAP+dUQD/r3EA/8GRAP/SsQD/5dEA////AAAAAAAvAwAAUAQAAHAGAACQCQAAsAoAAM8MAADwDgAA/yASAP8+MQD/XFEA/3pxAP+XkQD/trEA/9TRAP///wAAAAAALwAOAFAAFwBwACEAkAArALAANgDPAEAA8ABJAP8RWgD/MXAA/1GGAP9xnAD/kbIA/7HIAP/R3wD///8AAAAAAC8AIABQADYAcABMAJAAYgCwAHgAzwCOAPAApAD/EbMA/zG+AP9RxwD/cdEA/5HcAP+x5QD/0fAA////AAAAAAAsAC8ASwBQAGkAcACHAJAApQCwAMQAzwDhAPAA8BH/APIx/wD0Uf8A9nH/APeR/wD5sf8A+9H/AP///wAAAAAAGwAvAC0AUAA/AHAAUgCQAGMAsAB2AM8AiADwAJkR/wCmMf8AtFH/AMJx/wDPkf8A3LH/AOvR/wD///8AAAAAAAgALwAOAFAAFQBwABsAkAAhALAAJgDPACwA8AA+Ef8AWDH/AHFR/wCMcf8AppH/AL+x/wDa0f8A////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMCwsLCwsMCwkJCQkJCQkJDQ4ODg4ODQ4KCgoKCgoKCjc3Nzc3NzU2ICUkJCQkIiZPV1RUVFRVU0AxQUFBQUFBPDw8PDw8Oz0uLCsrKyssKFFeXF1bXF1aSURGRkZGRkY5OTk5OTk6OCMrKioqKiknUFxYWFhYXFlIQ0JCQkJCQjk5OTk5OTo4IysqKioqKSdQXFhYWFhYWUhDQkJCQkJCOTk5OTk5OjgjKyoqKiopJ1BcWFhYWFhZSENCQkJCQkI5OTk5OTk6OCMrKioqKiknUF1YWFhYWFpIQ0JCQkJCQjk5OTk5OTo4IysqKioqKSdQXFhYWFhYWUhDQkJCQkJCOTk5OTk5OjgjKyoqKiorJ1BcWFhYWFhYSENCQkJCQkI5OTk5OTk6OCMrKioqKisnUFxYWFhYWFlIQ0JCQkJCQjk5OTk5OTo4IysqKioqKydQXFhYWFhYWkhDQkJCQkJCOTk5OTk5Oj0jLCoqKiorJ1BcWFhYWFhZSENCQkJCQkI5OTk8OTk8PSMrKioqKisnUF1YWFhYWFlIQ0JEQkRCQjw8PDw8Ozs+Li0sLCssLShWXl1dXV1dW0pFR0dHR0dHMzMzMzMzNDIfISEdHSEhHktSTU1NTU5MPy8wMDAwMDAEBAQEBAQEBAICAgICAgICBQYGBgYGBQUDAwMDAwMDAwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAATExMTExMTEgAAEBEQERAQEBEQEBAQAQARExMTExMTEwAAAAAAAAAAEgAAAAAAAAAAAAAAAAAPBwAAAAAAAAAAAAAAAAAAAAAUAAAAAAAAAAAAAAAAAAASAAAAAAAAAAAAAAAAAAAAABwAGAAAAAAAAAAAAAAbABcAAAAAAAAAAAAAAAAAAAAAAAEBAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAHAAPAAAAAAAAAAARABgAAAAAAAAAAAAAAAAAAAAAAAAAFgAAGAAAAAAZAQAVAAAAAAAAAAAAAAAAAAAAAAAAAAAAHAgAAAcHAAABGgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABkSAAARGAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD/P/z//z/8//8f+P//n/n//4/x///Dw///4Af///gf/ygAAAAQAAAAIAAAAAEACAAAAAAAQAEAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAcEAAwGAAAAAAkAAAoOABIJAAACEQwABQQUAAIPFAAAEBYAERERABYWFgAaGhoAHBoaAB8fGgAiIiIAJCEiACQkIQApKSkANzc3ADw8PABFRUUAVFRUAHd3dwB6enoAtFgTALlaFAC1YA4AumMOAMNaAADDXAAAyV4AAMZpDwDKaw8A1mMAANZlAADaZgAAxWAVAMliFQAVqHkAFq19ADswxQA9MssAMy7RADEt1AAzLtsANS/YADgy5QA2MekANzLtADkz6QBBNdgAQjbcABOogwAUrYgAF7iFABi9hwAXu4kAGLyJABW4kAAVvJMAE5rLABSf0gADoNoAFanfAAKg4QADpuEAAKHlAAKl6QAAp+wAFazjABWt5AACr/gAA7DwAAOz9AADtPUAALH8AAC0/wDR/98A////AAAAAAACLwAABFAAAAZwAAAIkAAACrAAAAvPAAAO8AAAIP8SAD3/MQBb/1EAef9xAJj/kQC1/7EA1P/RAP///wAAAAAAFC8AACJQAAAwcAAAPZAAAEywAABZzwAAZ/AAAHj/EQCK/zEAnP9RAK7/cQDA/5EA0v+xAOT/0QD///8AAAAAACYvAABAUAAAWnAAAHSQAACOsAAAqc8AAMLwAADR/xEA2P8xAN7/UQDj/3EA6f+RAO//sQD2/9EA////AAAAAAAvJgAAUEEAAHBbAACQdAAAsI4AAM+pAADwwwAA/9IRAP/YMQD/3VEA/+RxAP/qkQD/8LEA//bRAP///wAAAAAALxQAAFAiAABwMAAAkD4AALBNAADPWwAA8GkAAP95EQD/ijEA/51RAP+vcQD/wZEA/9KxAP/l0QD///8AAAAAAC8DAABQBAAAcAYAAJAJAACwCgAAzwwAAPAOAAD/IBIA/z4xAP9cUQD/enEA/5eRAP+2sQD/1NEA////AAAAAAAvAA4AUAAXAHAAIQCQACsAsAA2AM8AQADwAEkA/xFaAP8xcAD/UYYA/3GcAP+RsgD/scgA/9HfAP///wAAAAAALwAgAFAANgBwAEwAkABiALAAeADPAI4A8ACkAP8RswD/Mb4A/1HHAP9x0QD/kdwA/7HlAP/R8AD///8AAAAAACwALwBLAFAAaQBwAIcAkAClALAAxADPAOEA8ADwEf8A8jH/APRR/wD2cf8A95H/APmx/wD70f8A////AAAAAAAbAC8ALQBQAD8AcABSAJAAYwCwAHYAzwCIAPAAmRH/AKYx/wC0Uf8AwnH/AM+R/wDcsf8A69H/AP///wAAAAAACAAvAA4AUAAVAHAAGwCQACEAsAAmAM8ALADwAD4R/wBYMf8AcVH/AIxx/wCmkf8Av7H/ANrR/wD///8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHBwcHBQUFBQgJCQkGBgYGLi4tKhofHxw+RURCNigoKDIyMTQmJCQhRk1MSjw4OTkvLzAzJSMiIEBMSEk7Nzc3Ly8wMyUjIiFATEhJOzc3Ny8vMDMlJCIgQExISTs3NzcyMjE0JiQkIUdNTUs8ODo6KyssKRkeHRs9Q0E/NScnJwMDAwMCAgICBAQEBAEBAQEREREOAQsLCwsLCwENEBAQAAAAABIAAAAAAAAPAAAAAAAAAAAWFwAAAAAAFQAAAAAAAAAAAAwYAAAACwAAAAAAAAAAAAAAFAoKEwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAPfvAADz7wAA+d8AAPw/AAA=</Image>

I think we should put the image in the shared folder and load it as resource
> ebay-es, ebay-in, ebay-nl are not used anywhere. Is that expected?

Oops. I half finished the patch. I'll fix that. Sorry. I actually was going to get a list of all the Indian builds I should put this in.

> Can you explain this setting? I don't think I understand what's going on, also for IE

So that setting allows us to use a different engine for different regions.

So if you are using the French version of Firefox, for instanace, and you are in Belgium, we'll use ebay-be instead of ebay-fr.

Basically that list says "plug this engine in for the other engine in this region"

>I think we should put the image in the shared folder and load it as resource

Good call.

And I am having a dev look it over.

And thanks for the icon!
Status: NEW → ASSIGNED
Priority: -- → P1
Tracking 57+ for this partner request especially if the patch is small. We need the patch done soon if this is destined to make 57.
Comment on attachment 8916045 [details]
Bug 1406164 - We're bringing eBay back.

https://reviewboard.mozilla.org/r/187304/#review193238

::: browser/locales/search/list.json:84
(Diff revision 3)
>        }
>      },
>      "an": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-es", "bing", "wikipedia-an", "ddg", "twitter"

Add ebay-es

::: browser/locales/search/list.json:98
(Diff revision 3)
>        }
>      },
>      "as": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "amazondotcom", "ddg", "wikipedia-as"

Add ebay-in

::: browser/locales/search/list.json:105
(Diff revision 3)
>        }
>      },
>      "ast": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-es", "bing", "diccionariu-alla", "ddg", "wikipedia-ast"

Add ebay-es

::: browser/locales/search/list.json:140
(Diff revision 3)
>        }
>      },
>      "bn-IN": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "amazondotcom", "bing", "ddg", "rediff", "wikipedia-bn"

Add ebay-in

::: browser/locales/search/list.json:147
(Diff revision 3)
>        }
>      },
>      "br": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-france", "amazon-france", "ddg", "freelang", "klask", "wikipedia-br"

Add ebay-fr

::: browser/locales/search/list.json:161
(Diff revision 3)
>        }
>      },
>      "ca": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "bing", "diec2", "ddg", "twitter", "wikipedia-ca"

Add ebay-es

::: browser/locales/search/list.json:182
(Diff revision 3)
>        }
>      },
>      "cy": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-en-GB", "amazon-en-GB", "ddg", "palasprint", "termau", "wikipedia-cy"

Add ebay-uk

::: browser/locales/search/list.json:203
(Diff revision 3)
>        }
>      },
>      "dsb": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-de", "bing", "amazondotcom-de", "ddg", "leo_ende_de", "wikipedia-dsb"

Add ebay-de

::: browser/locales/search/list.json:278
(Diff revision 3)
>        }
>      },
>      "eu": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo", "bing", "amazon-en-GB", "ddg", "elebila", "wikipedia-eu"

Add ebay-es

::: browser/locales/search/list.json:313
(Diff revision 3)
>        }
>      },
>      "fy-NL": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-fy-NL", "bing", "bolcom-fy-NL", "ddg", "marktplaats-fy-NL", "wikipedia-fy-NL"

Add ebay-nl

::: browser/locales/search/list.json:327
(Diff revision 3)
>        }
>      },
>      "gd": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-en-GB", "faclair-beag", "amazon-en-GB", "bbc-alba", "ddg", "wikipedia-gd"

Add ebay-uk

::: browser/locales/search/list.json:334
(Diff revision 3)
>        }
>      },
>      "gl": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-es", "amazon-en-GB", "ddg", "wikipedia-gl"

Add ebay-es

::: browser/locales/search/list.json:376
(Diff revision 3)
>        }
>      },
>      "hsb": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-de", "bing", "amazondotcom-de", "ddg", "leo_ende_de", "wikipedia-hsb"

Add ebay-de

::: browser/locales/search/list.json:467
(Diff revision 3)
>        }
>      },
>      "kn": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "bing", "amazondotcom", "ddg", "kannadastore", "wikipedia-kn"

Add ebay-in

::: browser/locales/search/list.json:516
(Diff revision 3)
>        }
>      },
>      "mai": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "bing", "ddg", "twitter", "wikipedia-hi"

Add ebay-in

::: browser/locales/search/list.json:530
(Diff revision 3)
>        }
>      },
>      "ml": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "webdunia", "bing", "ddg", "rediff", "wikipedia", "wikipedia-ml"

Add ebay-in

::: browser/locales/search/list.json:537
(Diff revision 3)
>        }
>      },
>      "mr": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "amazondotcom", "ddg", "rediff", "wikipedia-mr"

Add ebay-in

::: browser/locales/search/list.json:586
(Diff revision 3)
>        }
>      },
>      "or": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "bing", "amazondotcom", "ddg", "wikipedia-or"

Add ebay-in

::: browser/locales/search/list.json:621
(Diff revision 3)
>        }
>      },
>      "rm": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-ch", "bing", "ddg", "leo_ende_de-rm", "pledarigrond", "wikipedia-rm"

This one is tricky: it's spoken between Switzerland and Italy. I guess add ebay-ch

::: browser/locales/search/list.json:698
(Diff revision 3)
>        }
>      },
>      "te": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-in", "amazondotcom", "ddg", "wikipedia-te", "wiktionary-te"

Add ebay-in
Comment on attachment 8916045 [details]
Bug 1406164 - We're bringing eBay back.

https://reviewboard.mozilla.org/r/187304/#review193468

One more edit, but it looks good for the locales/search part

::: browser/locales/search/list.json:481
(Diff revision 4)
>        }
>      },
>      "lij": {
>        "default": {
>          "visibleDefaultEngines": [
>            "google", "yahoo-it", "bing", "amazon-it", "ddg", "paroledigenova-lij", "wikipedia-lij"

Missed this one: add "ebay-in" (it's spoken in Italy)
Attachment #8916045 - Flags: review?(francesco.lodolo) → review+
Backout by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/22eeb805d31c
Backed out changeset 915bdb6efcf6 for key-spacing ESLint failures in browser_eBay.js.
https://hg.mozilla.org/mozilla-central/rev/eefd55a8cc02
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Depends on: 1408313
There's confusion in the patch between ebay-uk and ebay-gb
Resubmitted with gb/uk fix. I built the langpack locally to verify.
https://hg.mozilla.org/mozilla-central/rev/e1863419e38b
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Depends on: 1408730
Flags: needinfo?(mozilla)
Comment on attachment 8916045 [details]
Bug 1406164 - We're bringing eBay back.

Approval Request Comment
[Feature/Bug causing the regression]: Add eBay to Firefox
[User impact if declined]: No eBay
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: bug 1408730 (artifact test fi)
[Is the change risky?]: Very low
[Why is the change risky/not risky?]: Adds search engine to list, no source code changes
[String changes made/needed]: None
Attachment #8916045 - Flags: approval-mozilla-beta?
Comment on attachment 8916045 [details]
Bug 1406164 - We're bringing eBay back.

Must fix, Beta57+
Attachment #8916045 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Mike Kaply [:mkaply] from comment #33)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Mike's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
For anyone running into trouble running browser/components/search/test/browser_searchEngine_behaviors.js in a local build, try a clobber and rebuild.
This worked for me and got rid of the assertion error 'null - ebay is installed'.
I've not run browser/components/search/test/browser_searchEngine_behaviors.js locally, but all my try pushes since a couple of days have seen browser/components/search/test/browser_searchEngine_behaviors.js fail systematically. Example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7601a2c6f9e2a5934bcf748d1ecec4a04cfbb887&group_state=expanded&selectedJob=138126292
I've had the same and a _local_ clobber fixed that for me too, I believe. Not sure how or why, but it did...
I'll take a look.
(In reply to Patrick Brosset <:pbro> from comment #38)
> I've not run
> browser/components/search/test/browser_searchEngine_behaviors.js locally,
> but all my try pushes since a couple of days have seen
> browser/components/search/test/browser_searchEngine_behaviors.js fail
> systematically. Example:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=7601a2c6f9e2a5934bcf748d1ecec4a04cfbb887&group_state=e
> xpanded&selectedJob=138126292

Patrick, can you see if the fix I checked in for bug 1409629 fixed this for you?

I didn't see that specific error in the try run i did with it:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1923fde635aa
(In reply to Mike Kaply [:mkaply] from comment #41)
> Patrick, can you see if the fix I checked in for bug 1409629 fixed this for
> you?
> 
> I didn't see that specific error in the try run i did with it:
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=1923fde635aa
\o/ Seems to be working fine for me: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e95acb58a6e8d7bdb7b0d162ca8faa7749bfe2ab
Thanks!
Depends on: 1408166
You need to log in before you can comment on or make changes to this bug.