1406173 - Don't pass --distribute to virtualenv

Status: RESOLVED DUPLICATE of bug 1297515

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Alex Gaynor [:Alex_Gaynor]]

Attachment: no-distribute.diff

This option is not respected on recent versions of virtualenv, and distribute has not been the recommended way of doing this for a long time:

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/python.py?q=testing%2Fmozharness%2Fmozharness%2Fbase%2Fpython.py&redirect_type=direct#420-421

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 8915733 [details] [diff] [review]
no-distribute.diff

Review of attachment 8915733 [details] [diff] [review]:
-----------------------------------------------------------------

This is obviously correct.

However, I'll point out that some parts of CI are using ancient versions of pip/virtualenv (from out-of-repo sources). Don't be surprised if this breaks something :(

Comment 2

[Gregory Szorc [:gps]]

It seems bug 1297515 may fix the "ancient pip/virtualenv" problem.

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Won't try to land until that's resolved; I really don't want to break the world.

Comment 4

[Andrew Halberstadt [:ahal]]

In that case you can probably dupe this to the other bug. The patch in bug 1297515 also removes --distribute.