Closed
Bug 1406173
Opened 7 years ago
Closed 7 years ago
Don't pass --distribute to virtualenv
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1297515
People
(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)
References
Details
Attachments
(1 file)
|
718 bytes,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
This option is not respected on recent versions of virtualenv, and distribute has not been the recommended way of doing this for a long time:
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/python.py?q=testing%2Fmozharness%2Fmozharness%2Fbase%2Fpython.py&redirect_type=direct#420-421
Attachment #8915733 -
Flags: review?(gps)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8915733 [details] [diff] [review]
no-distribute.diff
Review of attachment 8915733 [details] [diff] [review]:
-----------------------------------------------------------------
This is obviously correct.
However, I'll point out that some parts of CI are using ancient versions of pip/virtualenv (from out-of-repo sources). Don't be surprised if this breaks something :(
Attachment #8915733 -
Flags: review?(gps) → review+
|
|
||
Comment 2•7 years ago
|
||
It seems bug 1297515 may fix the "ancient pip/virtualenv" problem.
|
Assignee | |
Comment 3•7 years ago
|
||
Won't try to land until that's resolved; I really don't want to break the world.
Depends on: 1297515
|
||
Comment 4•7 years ago
|
||
In that case you can probably dupe this to the other bug. The patch in bug 1297515 also removes --distribute.
|
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•