Closed Bug 1406217 Opened 2 years ago Closed 2 years ago

webrender: preferences search bar looks broken/mispositioned

Categories

(Core :: Graphics: WebRender, defect, P1)

x86_64
All
defect

Tracking

()

VERIFIED FIXED
mozilla58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: darkspirit, Assigned: kats)

References

()

Details

(Keywords: nightly-community, Whiteboard: [wr-mvp])

Attachments

(1 file)

Kartikaya Gupta (email:kats@mozilla.com) from bug 1406008 comment 21
> (In reply to Jan Andre Ikenmeyer [:darkspirit] from bug 1406008 comment #19)
> > The preferences search bar looks broken/mispositioned (also in my Nightly), might be bug 1366295. (I don't know.)
> 
> Can you file a new bug for this? I saw it too, not sure what's going on there.


If I open devtools and remove "position: sticky" from ".search-container", it looks almost normal.
Whiteboard: [wr-mvp] [triage]
Priority: -- → P2
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
OS: Linux → All
I can repro this still, I think there's a coordinate space mismatch somewhere so we're causing the position-sticky item to double its top margin.
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Priority: P2 → P1
http://searchfox.org/mozilla-central/rev/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/layout/painting/nsDisplayList.cpp#7326

This needs to be a GetOffsetToCrossDoc, because the reference frame might be in an ancestor document, as is the case for about:preferences. The fix is trivial but I want to write a test case for it if I can.
Blocks: 1366295
No longer depends on: 1366295
Comment on attachment 8923799 [details]
Bug 1406217 - Fix computation of scrollframe's offset to the reference frame.

https://reviewboard.mozilla.org/r/194930/#review200716
Attachment #8923799 - Flags: review?(mstange) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e12eb0aa5165
Fix computation of scrollframe's offset to the reference frame. r=mstange
https://hg.mozilla.org/mozilla-central/rev/e12eb0aa5165
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Largely fixed in Nightly 58 x64 20171104100412 de_DE @ Debian Testing (KDE, Radeon RX480).

Scrolling by Home/End, Page Up/Down, Scrollbar and Up/Down is fine,
but it jumps a bit up and down when scrolling by mousewheel.
(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> but it jumps a bit up and down when scrolling by mousewheel.

This should be addressed by bug 1411627 (I have patches for that, waiting on servo/webrender#1977 to land).
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #9)
> (In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> > but it jumps a bit up and down when scrolling by mousewheel.
> 
> This should be addressed by bug 1411627 (I have patches for that, waiting on servo/webrender#1977 to land).

Verified fixed in
Nightly 58 x64 20171108110838 de_DE f63559d7e6a570e4e73ba367964099394248e18d @ Debian Testing (KDE, Radeon RX480).
Thank you!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.