1406217 - webrender: preferences search bar looks broken/mispositioned

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Kartikaya Gupta (email:[e-mail]) from bug 1406008 comment 21
> (In reply to Jan Andre Ikenmeyer [:darkspirit] from bug 1406008 comment #19)
> > The preferences search bar looks broken/mispositioned (also in my Nightly), might be bug 1366295. (I don't know.)
> 
> Can you file a new bug for this? I saw it too, not sure what's going on there.


If I open devtools and remove "position: sticky" from ".search-container", it looks almost normal.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I can repro this still, I think there's a coordinate space mismatch somewhere so we're causing the position-sticky item to double its top margin.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

http://searchfox.org/mozilla-central/rev/1ebd2eff44617df3b82eea7d2f3ca1b60cc591a0/layout/painting/nsDisplayList.cpp#7326

This needs to be a GetOffsetToCrossDoc, because the reference frame might be in an ancestor document, as is the case for about:preferences. The fix is trivial but I want to write a test case for it if I can.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd9de7f44125f34cba0be423969a418fbd72f695

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1406217 - Fix computation of scrollframe's offset to the reference frame.

We need to get the offset across documents boundaries, since the scrollframe
might be inside a subdocument. In such cases we were previously computing
a (incorrect) zero offset for the scrollframe, which was throwing off the
margin for the sticky items inside the scrollframe.

Review commit: https://reviewboard.mozilla.org/r/194930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194930/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8923799 [details]
Bug 1406217 - Fix computation of scrollframe's offset to the reference frame.

https://reviewboard.mozilla.org/r/194930/#review200716

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e12eb0aa5165
Fix computation of scrollframe's offset to the reference frame. r=mstange

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e12eb0aa5165

Comment 8

[Darkspirit]

Largely fixed in Nightly 58 x64 20171104100412 de_DE @ Debian Testing (KDE, Radeon RX480).

Scrolling by Home/End, Page Up/Down, Scrollbar and Up/Down is fine,
but it jumps a bit up and down when scrolling by mousewheel.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> but it jumps a bit up and down when scrolling by mousewheel.

This should be addressed by bug 1411627 (I have patches for that, waiting on servo/webrender#1977 to land).

Comment 10

[Darkspirit]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #9)
> (In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #8)
> > but it jumps a bit up and down when scrolling by mousewheel.
> 
> This should be addressed by bug 1411627 (I have patches for that, waiting on servo/webrender#1977 to land).

Verified fixed in
Nightly 58 x64 20171108110838 de_DE f63559d7e6a570e4e73ba367964099394248e18d @ Debian Testing (KDE, Radeon RX480).
Thank you!