1406265 - [BC] SetIStartStart(), IsIStartStart(), IsBStartStart() and SetBStartStart() are not well used

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement, P3)

Description

[Ya-Chieh Wu (inactive)]

I am tracing the table code for Bug 1405929 and it is pains for me that we don't use SetIStartStart(), IsIStartStart(), IsBStartStart() and SetBStartStart() properly. For SetIStartStart(), we don't even use it. I would like to change the places where we should use inline SetXXX() or inline IsXXX() instead of changing/getting the member values directly.

Comment 1

[Ya-Chieh Wu (inactive)]

Attachment: 0001-Bug-1406265-use-SetXXX-and-IsXXX-instead-of-chaning-.patch

Comment 2

[Ya-Chieh Wu (inactive)]

Comment on attachment 8915813 [details] [diff] [review]
0001-Bug-1406265-use-SetXXX-and-IsXXX-instead-of-chaning-.patch

David, 

In this patch, I changed the places where we directly got/modified the |mBStartStart| and |mIStartStart| instead of calling the functions we created. This could make it clear where we change/get the |mBStartStart| and |mIStartStart|. 

try looks ok: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06cd5a49a07524feaa7b24a16a1dbec5ce6ba376&selectedJob=135297404

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8915813 [details] [diff] [review]
0001-Bug-1406265-use-SetXXX-and-IsXXX-instead-of-chaning-.patch

># HG changeset patch
># User Ya-Chieh Wu <[e-mail]>
>
>Bug 1406265 - use SetXXX and IsXXX instead of chaning the member directly

s/chaning/changing/, and probably s/XXX/*/


(Also, it would be better for the Is* and Set* methods to be defined right where they're declared rather than being defined at the end of the header file.)

Comment 4

[Ya-Chieh Wu (inactive)]

Attachment: 0001-Bug-1406265-use-Set-and-Is-instead-of-changing-getti.patch

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3d68639a77660ef80b4e015605e565296dfb6ce

Comment 5

[Ya-Chieh Wu (inactive)]

try looks ok.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc7f5199a0e2
use Set* and Is* instead of changing/getting the member directly. r=dbaron

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fc7f5199a0e2