1406281 - Restyle CallbackAndVarCacheOrder.cpp

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

Following on from bug #1406280

Process:

- Patch 1: Run clang-format to fix whitespace.

- Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format.

- Squash the patches together before landing.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp (clang-format). .

Review commit: https://reviewboard.mozilla.org/r/187072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187072/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp (manual). .

Review commit: https://reviewboard.mozilla.org/r/187074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187074/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8915840 [details]
Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187072/#review192094


C/C++ static analysis found 10 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:140
(Diff revision 1)
>    SetFunc(prefName2, value2);
>    ASSERT_EQ(var2, value2);
>    ASSERT_TRUE(closure2.called);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Bool) {
> +TEST(CallbackAndVarCacheOrder, Bool)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:140
(Diff revision 1)
>    SetFunc(prefName2, value2);
>    ASSERT_EQ(var2, value2);
>    ASSERT_TRUE(closure2.called);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Bool) {
> +TEST(CallbackAndVarCacheOrder, Bool)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:145
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Bool) {
> +TEST(CallbackAndVarCacheOrder, Bool)
> +{
>    RunTest<bool>("test_pref.bool.1", "test_pref.bool.2", false, true);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Int) {
> +TEST(CallbackAndVarCacheOrder, Int)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:145
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Bool) {
> +TEST(CallbackAndVarCacheOrder, Bool)
> +{
>    RunTest<bool>("test_pref.bool.1", "test_pref.bool.2", false, true);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Int) {
> +TEST(CallbackAndVarCacheOrder, Int)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:150
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Int) {
> +TEST(CallbackAndVarCacheOrder, Int)
> +{
>    RunTest<int32_t>("test_pref.int.1", "test_pref.int.2", -2, 3);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Uint) {
> +TEST(CallbackAndVarCacheOrder, Uint)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:150
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Int) {
> +TEST(CallbackAndVarCacheOrder, Int)
> +{
>    RunTest<int32_t>("test_pref.int.1", "test_pref.int.2", -2, 3);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Uint) {
> +TEST(CallbackAndVarCacheOrder, Uint)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:155
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Uint) {
> +TEST(CallbackAndVarCacheOrder, Uint)
> +{
>    RunTest<uint32_t>("test_pref.uint.1", "test_pref.uint.2", 4u, 5u);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, AtomicUint) {
> +TEST(CallbackAndVarCacheOrder, AtomicUint)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:155
(Diff revision 1)
> -TEST(CallbackAndVarCacheOrder, Uint) {
> +TEST(CallbackAndVarCacheOrder, Uint)
> +{
>    RunTest<uint32_t>("test_pref.uint.1", "test_pref.uint.2", 4u, 5u);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, AtomicUint) {
> +TEST(CallbackAndVarCacheOrder, AtomicUint)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:161
(Diff revision 1)
> -  RunTest<uint32_t,Atomic<uint32_t,Relaxed>>("test_pref.atomic_uint.1",
> -                                             "test_pref.atomic_uint.2",
> -                                             6u, 7u);
> +{
> +  RunTest<uint32_t, Atomic<uint32_t, Relaxed>>(
> +    "test_pref.atomic_uint.1", "test_pref.atomic_uint.2", 6u, 7u);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Float) {
> +TEST(CallbackAndVarCacheOrder, Float)

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

::: modules/libpref/test/gtest/CallbackAndVarCacheOrder.cpp:161
(Diff revision 1)
> -  RunTest<uint32_t,Atomic<uint32_t,Relaxed>>("test_pref.atomic_uint.1",
> -                                             "test_pref.atomic_uint.2",
> -                                             6u, 7u);
> +{
> +  RunTest<uint32_t, Atomic<uint32_t, Relaxed>>(
> +    "test_pref.atomic_uint.1", "test_pref.atomic_uint.2", 6u, 7u);
>  }
>  
> -TEST(CallbackAndVarCacheOrder, Float) {
> +TEST(CallbackAndVarCacheOrder, Float)

Warning: Use '= delete' to prohibit calling of a special member function [clang-tidy: modernize-use-equals-delete]

Comment 4

[Nicholas Nethercote [inactive]]

> > -TEST(CallbackAndVarCacheOrder, Float) {
> > +TEST(CallbackAndVarCacheOrder, Float)
> 
> Warning: Use '= delete' to prohibit calling of a special member function
> [clang-tidy: modernize-use-equals-delete]

All these warnings are bogus; the static analysis is handling the TEST macros badly. I filed https://github.com/mozilla-releng/services/issues/658 for this.

Comment 5

[Eric Rahm [:erahm]]

Comment on attachment 8915840 [details]
Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187072/#review192912

Comment 6

[Eric Rahm [:erahm]]

Comment on attachment 8915841 [details]
Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp (manual). .

https://reviewboard.mozilla.org/r/187074/#review192914

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d16958d3126b9dea70ee9849779fd4afc41ff0ac
Bug 1406281 - Restyle CallbackAndVarCacheOrder.cpp. r=erahm.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d16958d3126b