1406337 - Remove comment handling from media type parser

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Anne (:annevk)]

> We include '(' in the trailing trim set to catch media-type comments,
> which are not at all standard, but may occur in rare cases.

Safari does not have this behavior and Edge does not have it for parameter values (and barely for media types). Let's remove it.

See https://github.com/whatwg/mimesniff/issues/33 for further analysis. (I'm planning to refine the media/MIME type parser in that standard to get browsers more closely aligned. Eventually there will be tests too, once I know what I think the details should be like. Feedback appreciated.)

Comment 1

[Anne (:annevk)]

It seems Chrome is willing to fix this per https://bugs.chromium.org/p/chromium/issues/detail?id=772343 though they'd appreciate some preliminary feedback from Firefox.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Based on the current information. Looks like we are not going to implement this soon, put it in our P3 bucket.

Comment 3

[j.j.]

Chrome fixed this now
https://bugs.chromium.org/p/chromium/issues/detail?id=772343

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 5

[Dylan]

Attachment: Bug 1406337 - Removed comment handling from net_ParseMediaType. r=kershaw

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21ba56d4086b
Removed comment handling from net_ParseMediaType. r=kershaw,necko-reviewers

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/21ba56d4086b