1406340 - rm ArgumentsRectifierReg

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

The rectifier trampoline can just load argc from the stack (and is actually already doing that). This simplifies a bunch of code and is necessary for bug 1405994. 

 14 files changed, 15 insertions(+), 73 deletions(-)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8915925 [details] [diff] [review]
Patch

Review of attachment 8915925 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!

::: js/src/jit/BaselineCacheIRCompiler.cpp
@@ -529,5 @@
>  
>      Register obj = allocator.useRegister(masm, reader.objOperandId());
>      Address getterAddr(stubAddress(reader.stubOffset()));
>  
> -    AutoScratchRegisterExcluding code(allocator, masm, ArgumentsRectifierReg);

according to searchfox, AutoScratchRegisterExcluding could now be removed \o/

::: js/src/jit/Lowering.cpp
@@ +499,5 @@
>  
>  void
>  LIRGenerator::visitCall(MCall* call)
>  {
>      MOZ_ASSERT(CallTempReg0 != CallTempReg1);

pre-existing: could it be a static_assert?

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

Thanks for the quick review!

This removes AutoScratchRegisterExcluding, fixes a bug on x64, and removes the CallTempReg0 != CallTempReg1 assert as discussed on IRC.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b632d01bb670
Remove ArgumentsRectifierReg and just load argc from the stack. r=bbouvier

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b632d01bb670