1406467 - Web Authentication - WD-07 Updates to Make Assertion

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

More needs to happen in Make Assertion:
    * Check for authenticatorAttachment
    * Check for requireUserVerification
    * Assert options.publicKey is present
    * Evaluate transports

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

(Just a note, we need to remember to push those changes to u2f-hid-rs as well.)

Comment 2

[Phabricator Automation]

Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D338#8363

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Adding Smaug to the reviewer list, as there's WebIDL. (I guess this didn't sync from Phabricator...)

Comment 4

[Phabricator Automation]

Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Olli Pettay [:smaug] has approved the revision.

https://phabricator.services.mozilla.com/D338#8761

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Interesting, r+ in Phabricator didn't clear this review

Comment 6

[J.C. Jones [:jcj] (he/they)]

Thanks, Olli.

Tim: I think you'll have to land this when you've a chance.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b0bbd94352d
Web Authentication - WD-07 Updates to Make Assertion r=jcj,smaug

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7b0bbd94352d