Closed Bug 1406467 Opened 3 years ago Closed 2 years ago

Web Authentication - WD-07 Updates to Make Assertion

Categories

(Core :: DOM: Device Interfaces, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Future
Tracking Status
firefox57 --- unaffected
firefox59 --- fixed

People

(Reporter: jcj, Assigned: ttaubert)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [webauthn][webauthn-wd07])

Attachments

(1 file)

More needs to happen in Make Assertion:
    * Check for authenticatorAttachment
    * Check for requireUserVerification
    * Assert options.publicKey is present
    * Evaluate transports
(Just a note, we need to remember to push those changes to u2f-hid-rs as well.)
Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D338#8363
Attachment #8937369 - Flags: review+
Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Adding Smaug to the reviewer list, as there's WebIDL. (I guess this didn't sync from Phabricator...)
Attachment #8937369 - Flags: review?(bugs)
Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Olli Pettay [:smaug] has approved the revision.

https://phabricator.services.mozilla.com/D338#8761
Attachment #8937369 - Flags: review+
Comment on attachment 8937369 [details]
Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug

Interesting, r+ in Phabricator didn't clear this review
Attachment #8937369 - Flags: review?(bugs)
Thanks, Olli.

Tim: I think you'll have to land this when you've a chance.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Flags: needinfo?(ttaubert)
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b0bbd94352d
Web Authentication - WD-07 Updates to Make Assertion r=jcj,smaug
Flags: needinfo?(ttaubert)
https://hg.mozilla.org/mozilla-central/rev/7b0bbd94352d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Attachment #8937369 - Attachment description: Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj → Bug 1406467 - Web Authentication - WD-07 Updates to Make Assertion r?jcj r?smaug
You need to log in before you can comment on or make changes to this bug.