1406486 - provide nsClientAuthRememberEntry/nsCertOverrideEntry with move constructors

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Nathan Froyd [:froydnj]]

Move constructors are more appropriate for these classes, since the
underlying hashtable code will be moving them around, not copying them.
We can take this opportunity to fix a bug in nsClientAuthRememberEntry:
it wasn't transferring the value of mEntryKey, which would have been
disastrous if the underlying hash table was ever resized.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: provide nsClientAuthRememberEntry/nsCertOverrideEntry with move constructors

These have the potential to be more efficient, and we're also fixing a bug in
passing.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8916083 [details] [diff] [review]
provide nsClientAuthRememberEntry/nsCertOverrideEntry with move constructors

Review of attachment 8916083 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: security/manager/ssl/nsClientAuthRemember.h
@@ +62,5 @@
>      {
>      }
>  
> +    nsClientAuthRememberEntry(nsClientAuthRememberEntry&& aToMove)
> +      : mSettings(mozilla::Move(aToMove.mSettings))

I realize we've got unified compilation, but generally in PSM we've been directly including headers where we use what they declare rather than relying on getting them indirectly (also might be a nice opportunity to re-sort the includes in this file).

@@ -66,2 @@
>      {
> -      mSettings = aToCopy.mSettings;

Siiiiiiiiiiiiiiiiiiiiiigh. Thanks.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1df1edaf60c3
provide nsClientAuthRememberEntry/nsCertOverrideEntry with move constructors; r=keeler

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1df1edaf60c3