1406509 - [RTL] Search results are truncated and left aligned in RTL languages

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Arash Mousavi [:Arash-M]]

Attachment: suggestion results in RTL

Since the yesterday update, when typing in the addressbar, the suggestions are left aligned and mostly truncated. See the attachment.

Firefox Nightly 58.0a1 (2017-10-06)
Linux 64-bit
The issue first appeared on build 2017/10/05

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Does this happen in beta 57 as well?

Comment 2

[Arash Mousavi [:Arash-M]]

Downloaded and tested latest beta version from https://www.mozilla.org/fa/firefox/channel/desktop/ and it does have the same problem.

Firefox 57.0.b6
Linux 64bit

Comment 3

[Marco Bonardo [:mak]]

Maybe related to the change in bug 1402272?

Comment 4

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: very visible regression in Address Bar Usability.

Comment 5

[Marcia Knous [:marcia]]

(In reply to Marco Bonardo [::mak] from comment #4)
> [Tracking Requested - why for this release]: very visible regression in
> Address Bar Usability.

Tracking 57+ for this regression in RTL.

Comment 6

[:Paolo Amadini]

Attachment: Bug 1406509 - Search results are truncated and left aligned in RTL languages.

Review commit: https://reviewboard.mozilla.org/r/188000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188000/

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8916968 [details]
Bug 1406509 - Search results are truncated and left aligned in RTL languages.

https://reviewboard.mozilla.org/r/188000/#review193196

It makes sense, I didn't have the time to actually test the patch, but I assume you did :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b17cdf9d3756
Search results are truncated and left aligned in RTL languages. r=mak

Comment 9

[:Paolo Amadini]

(In reply to Marco Bonardo [::mak] from comment #7)
> It makes sense, I didn't have the time to actually test the patch, but I
> assume you did :)

Yes, I tested the results and the notification on new profiles on Mac OS X, but for uplift it makes sense for QA to test this on other platforms too, even if the code is quite likely to work the same everywhere.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b17cdf9d3756

Comment 12

[Marco Bonardo [:mak]]

Comment on attachment 8916968 [details]
Bug 1406509 - Search results are truncated and left aligned in RTL languages.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1402272 
[User impact if declined]: the Address bar results are completely unusable on RTL locales
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes, I just did on Win10x64
[Needs manual test from QE? If yes, steps to reproduce]: yes, checking the location bar popup in an RTL build, or changing intl.uidirection = 1 and intl.uidirection.en = "rtl" and restarting the browser.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not particularly
[Why is the change risky/not risky?]: The changes are limited to the RTL case, that is already broken
[String changes made/needed]: none

Comment 13

[Itiel]

Verified fixed on latest Nightly.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916968 [details]
Bug 1406509 - Search results are truncated and left aligned in RTL languages.

Severe recent regression, fix was verified on Nightly, beta57+

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/94cb46858593

Comment 16

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I was able to reproduce the initial issue on 58.0a1 (2017-10-06). I can confirm that 58.0a1 (2017-10-12) and 57.0b8 build3 (20171013042429) are resolved fixed, using Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12.1.