1406525 - Remove nsIDOMHTMLLinkElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuing post-addon-deprecation XPCOM interface cleanup

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1406525 - Remove nsIDOMHTMLLinkElement;

Review commit: https://reviewboard.mozilla.org/r/187394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187394/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8916148 [details]
Bug 1406525 - Remove nsIDOMHTMLLinkElement;

https://reviewboard.mozilla.org/r/187394/#review192474

There are two comm-central uses of `instanceof Components.interfaces.nsIDOMHTMLLinkElement`.  Please file a bug on them to switch to getClassName().

r=me with the nit below.

::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp:538
(Diff revision 1)
> -    nsCOMPtr<nsIDOMHTMLLinkElement> nodeAsLink = do_QueryInterface(aNode);
> -    if (nodeAsLink) {
> +    if (content->IsHTMLElement(nsGkAtoms::link)) {
> +        RefPtr<dom::HTMLLinkElement> nodeAsLink = dom::HTMLLinkElement::FromContent(content);

You can combine these as:

    if (auto nodeAsLink = dom::HTMLLinkElement::FromContent(content)) {
    
and then you only check the tagname once.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8916148 [details]
Bug 1406525 - Remove nsIDOMHTMLLinkElement;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187394/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f99c758cd03e
Remove nsIDOMHTMLLinkElement; r=bz

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/b4c98dfafc02 for Windows build bustage, https://treeherder.mozilla.org/logviewer.html#?job_id=135464356&repo=autoland

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/212ceaf885b0
Remove nsIDOMHTMLLinkElement; r=bz

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/212ceaf885b0