1406673 - Active tab doesn't have a right-hand side border if it is the last tab in tab overflow

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Oriol Brufau [:Oriol]]

Attachment: screenshot.png

1. Install https://addons.mozilla.org/en-US/firefox/addon/the-snowy-mountains-theme/
2. Set browser.tabs.tabMinWidth=100
3. Keep opening tabs (Ctrl+T) until the tabbar overflows

Result: There is no tab separator after the last tab.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c18b5243c8705c4b73319d346e8628ab5dcb9228&tochange=40ef1df3618bc5ec673464bfac9187f8b62ccae4

Comment 1

[Johann Hofmann [:johannh]]

Just to clarify, the regression from bug 1391539 is only that the active tab doesn't have a border on the right-hand side if it's the last tab in overflow.

Comment 2

[Edo Karabas]

Attachment: bug.webm

Hi Johann, I have recorded a video regarding bug/s with the tab separators. When moving tabs in the tabstrip, these separators turn to black, or disappearing in case of the last tab (before "+") and also it is slightly changing tab width after moving animation is finished. Should I file a new bug, or are you going to cover everything here ?

Comment 3

[Johann Hofmann [:johannh]]

(In reply to Eddward from comment #2)
> Created attachment 8916304 [details]
> bug.webm
> 
> Hi Johann, I have recorded a video regarding bug/s with the tab separators.
> When moving tabs in the tabstrip, these separators turn to black, or
> disappearing in case of the last tab (before "+") and also it is slightly
> changing tab width after moving animation is finished. Should I file a new
> bug, or are you going to cover everything here ?

Hi Eddward,

can you file individual bugs for all three issues blocking bug 1391539, please? Thank you!

Comment 4

[Johann Hofmann [:johannh]]

This will be fixed by bug 1406691.

Comment 5

[roxleitan]

Verified fixed using the latest Nightly 58.0a1 (2017-10-16) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.