1406782 - Assertion failure: mBeforeUnloadListenerCount > 0, at dom/base/nsGlobalWindow.cpp:13573

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

Attachment: Windows Debug Log

1. https://chelyabinsk.tele2.ru/lk/services

2. Assertion failure: mBeforeUnloadListenerCount > 0, at z:/build/build/src/dom/base/nsGlobalWindow.cpp:13573

#01: nsGlobalWindow::EventListenerAdded(nsIAtom *) [dom/base/nsGlobalWindow.cpp:13571]
#02: mozilla::EventListenerManager::AddEventListenerInternal(mozilla::dom::CallbackObjectHolder<mozilla::dom::EventListener,nsIDOMEventListener>,mozilla::EventMessage,nsIAtom *,nsTSubstring<char16_t> const &,mozilla::EventListenerFlags const &,bool,bool) [dom/events/EventListenerManager.cpp:423]
#03: mozilla::EventListenerManager::AddEventListenerByType(mozilla::dom::CallbackObjectHolder<mozilla::dom::EventListener,nsIDOMEventListener>,nsTSubstring<char16_t> const &,mozilla::EventListenerFlags const &) [dom/events/EventListenerManager.cpp:700]
#04: mozilla::EventListenerManager::AddEventListener(nsTSubstring<char16_t> const &,mozilla::dom::CallbackObjectHolder<mozilla::dom::EventListener,nsIDOMEventListener>,mozilla::dom::AddEventListenerOptionsOrBoolean const &,bool) [dom/events/EventListenerManager.cpp:1409]
#05: mozilla::EventListenerManager::AddEventListener(nsTSubstring<char16_t> const &,mozilla::dom::EventListener *,mozilla::dom::AddEventListenerOptionsOrBoolean const &,bool) [dom/events/EventListenerManager.h:286]
#06: nsGlobalWindow::AddEventListener(nsTSubstring<char16_t> const &,mozilla::dom::EventListener *,mozilla::dom::AddEventListenerOptionsOrBoolean const &,mozilla::dom::Nullable<bool> const &,mozilla::ErrorResult &) [dom/base/nsGlobalWindow.cpp:10414]
#07: mozilla::dom::EventTargetBinding::addEventListener [s3:gecko-generated-sources:65833a76a2cf83c5ba1be9f81ddb003d6c6adfe4ae20239d24a6b34896c038b3cffc89f0b4ce53eb74fb080135136f8b321f5126b42bf56f973306af9dbf50a8/dom/bindings/EventTargetBinding.cpp::851]
#08: mozilla::dom::EventTargetBinding::genericMethod [s3:gecko-generated-sources:65833a76a2cf83c5ba1be9f81ddb003d6c6adfe4ae20239d24a6b34896c038b3cffc89f0b4ce53eb74fb080135136f8b321f5126b42bf56f973306af9dbf50a8/dom/bindings/EventTargetBinding.cpp::1150]

Windows Nightly/58, Beta/57

Assertion added in bug 1336763

Comment 1

[Bob Clary [:bc] (inactive)]

Note bughunter was able to reproduce on Linux *ASAN* builds but I was unable to do so with a local downloaded asan build on Fedora 26.

Comment 2

[Jim Mathies [:jimm]]

Hey Mike, can you help triage this for 57?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hm. Hard for me to get a sense of how bad this is just yet.

Hey bc, how do I reproduce this? I couldn't reproduce it on a debug build just by visiting https://chelyabinsk.tele2.ru/lk/services ... is there some set of steps I have to follow to his the assertion?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

s/his/hit

Comment 5

[Bob Clary [:bc] (inactive)]

I resubmitted the url to bughunter and it reproduced on Beta/57 and Nightly/58 on 64 bit Windows 10 and Linux (Fedora and Ubuntu) though it was not 100% reliable.

I couldn't reproduce locally on a recent custom debug build on Fedora but could reproduce manually using the bughunter vms on Windows 7 and Fedora just by loading the url. I did need to fully clear the history on Windows before it would reproduce again.

When I was successful in reproducing, I just loaded the url and it asserted with no other steps necessary. I'll put it in a reload loop here locally to see if that helps.

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Bug 1543251 removed that assertion during a refactor, which may have fixed the root cause altogether.