1406815 - stylo: hard-assert more invariants in HashMap

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Bobby Holley (:bholley)]

I'm still hoping to catch something interesting with the canaries in bug 1406220. However, while it's still a bit too soon to say, we have some partial indicators that we're crashing on non-poison-valued garbage addresses even after bug 1405879.

Having also ruled out external corruption of our buffer via bug 1403397, the only remaining explanation I can think of is that we're somehow accessing memory outside of our buffer. We should be able to detect this with some hard-asserts around RawBucket.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d62618a74d738ef530f2b7aa899a82227729d02

Comment 2

[Bobby Holley (:bholley)]

Attachment: Assert more things in hashtables. v1

MozReview-Commit-ID: H8jKywUewcZ

Comment 3

[Bobby Holley (:bholley)]

Attachment: interdiff

Had to add a few fixes for orange found on try. At least the asserts are thorough. :-)

Comment 4

[Bobby Holley (:bholley)]

https://github.com/servo/servo/pull/18789

Comment 5

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/autoland/rev/1636e8da864c