1406880 - Decide where multiline Pattern spans should start

Status: RESOLVED FIXED

(L20n :: JS Library, enhancement)

Description

[Staś Małolepszy :stas]

Bug 1397234 changed how Patterns spans are calculated. Quoting https://github.com/projectfluent/fluent.js/pull/76#issuecomment-333573836:

    key = Value
         ^---- Pattern span start before bug 1397234

    key = Value
          ^---- Pattern span start after bug 1397234

Multiline Patterns were changed as follows (the Github comment has it wrong):

    key =
         ^---- Pattern span start before bug 1397234
        Value

    key =
        Value
    ^---- Pattern span start after bug 1397234

I'm not sure if that's good or bad. Should the Patterns start at the first meaningful character instead? Like so:

    key =
        Value
        ^---- Pattern span start after bug 1397234

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

My intuitive guess would be that we want to do what you suggest in your last snippet - since we remove leading white spaces, we should start the span on the first non-white character of the value.

Comment 2

[Axel Hecht [:Pike]]

Same here, last snippet.

Comment 3

[Staś Małolepszy :stas]

This was fixed in passing by https://github.com/projectfluent/fluent.js/commit/4d1a41fb7e21af01d582e36b29bc8e20ee731dba.