1406892 - Hamburger menu glitches after trying to access the Library menu from the toolbar

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P4)

Description

[Emil Ghitta, QA [:emilghitta]]

[Affected versions]:
Firefox 57.0b6 
Firefox 58.0a1 

[Affected platforms]:
- Ubuntu 16.04 x64

[Unaffected platforms]:
- Windows 10 64bit
- macOS 10.11.6

[Steps to reproduce]:
1. Start Firefox.
2. Open the Hamburger menu.
3. Access the Library sub menu.
4. Click on the Library menu from the toolbar.

[Expected result]:
The Library menu from the toolbar is opened without issues.

[Actual result]:
The Library menu is not accessible after switching from the Hamburger menu.
Also the Hamburger menu glitches while trying to repeat step 2.

[Regression range]:
This is a recent regression:
Last good revision: af23e7b6eb9395aecf2a255316da782ca618750a
First bad revision: 35acf942df34d075d1a181db6feeec0a9904f27b
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=af23e7b6eb9395aecf2a255316da782ca618750a&tochange=35acf942df34d075d1a181db6feeec0a9904f27b


[Additional notes]:
Form more information regarding this issue please observe the following screencast: https://drive.google.com/open?id=0BzOkHBmdnAoaUlBLQzFlbXVvQnM

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Mike!

It seems that the fix for Bug 1401991 may have caused this regression.

Can you have a look into this?

Thanks!

Comment 2

[Mike de Boer [:mikedeboer]]

Might be that my patch in bug 1407591 also solves this glitch.
I'll ask for verification once it lands.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Might be that my patch in bug 1407591 also solves this glitch.
> I'll ask for verification once it lands.

Mike, this came up in regression triage today. Have you verified if your patch fixed this yet?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Panos Astithas [:past] (please ni?) from comment #3)
> (In reply to Mike de Boer [:mikedeboer] from comment #2)
> > Might be that my patch in bug 1407591 also solves this glitch.
> > I'll ask for verification once it lands.
> 
> Mike, this came up in regression triage today. Have you verified if your
> patch fixed this yet?

Comment 5

[Mike de Boer [:mikedeboer]]

No, but I don't see this issue anymore, regardless. I consider this fixed, would be nice if Emil can verify it!

Comment 6

[Emil Ghitta, QA [:emilghitta]]

Hi Mike!

This issue is verified fixed using Firefox 60.0a1 (BuildId:20180302104326) on Ubuntu 16.04 64bit.

It seems that this issue is reproducible using Firefox 59.0b14 (BuildId:20180301022608).

Unfortunately,this issue seems to be riding to release 59.

Comment 7

[:Gijs (he/him)]

(In reply to Emil Ghitta, QA [:emilghitta] from comment #6)
> Hi Mike!
> 
> This issue is verified fixed using Firefox 60.0a1 (BuildId:20180302104326)
> on Ubuntu 16.04 64bit.
> 
> It seems that this issue is reproducible using Firefox 59.0b14
> (BuildId:20180301022608).
> 
> Unfortunately,this issue seems to be riding to release 59.

We already shipped this in 58, so this is unfortunate but I don't think there's much we can do at this point in the cycle. I expect some of Paolo's patches fixed this, but uplifting all of them to 59 at this point is too risky.

Comment 8

[David Olah]

Based on Comment 6 and Comment 7, I am marking this issue as verified.